New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with isort new release v5.0.0 #88
Comments
It looks like Since Semantic Versioning (or a close approximation) is widely used in the Python community, I've found pinning the major version of dependencies to be an excellent way to minimize breakage for my users. (And once the next major version stabilizes enough to work well, expanding or adjusting the ranges.) |
This should be reverted once flake8-isort fixes the compatibility. Ref: gforcada/flake8-isort#88
My quick-fix for tox:
|
Do not install the latest isort because it currently breaks flake8-isort. This pinning should be removed as soon as gforcada/flake8-isort#88 is resolved.
Did the same hotfix: ansible/pylibssh@2d7b003. |
* Closes #1530 * Clean up some wording and comments * Pin isort version to fix flake8 issue (gforcada/flake8-isort#88)
flake8-isort has [pinned itself to isort 4.x](gforcada/flake8-isort#88), and [so has pylint](https://github.com/PyCQA/pylint/blob/master/pylint/__pkginfo__.py#L41), but dephell hits some kind of infinite recursion trying to resolve this between those two packages, and the unqualified `isort[pyproject]` dependency in pyproject.toml. By restricting isort, dephell can complete installing.
This pinning should be removed as soon as gforcada/flake8-isort#88 is resolved. Signed-off-by: Marco Nenciarini <marco.nenciarini@2ndquadrant.it>
Fixed in flake8-isort 3.0.1. |
@153957 it is not a fix. It is a workaround that avoids isort v.5.0.x. See #89 (comment) |
We just got an issue in Pyramid that refers to the isort 5.0.0 upgrade guide. Perhaps that will be of assistance to updating flake8-isort? |
^ Fixed link to upgrade guide: https://github.com/timothycrosley/isort/blob/develop/docs/upgrade_guides/5.0.0.md |
Do not install the latest isort because it currently breaks flake8-isort. This pinning should be removed as soon as gforcada/flake8-isort#88 is resolved.
@153957 - thanks for the link. Sadly, that doesn't discuss the API that I did some prototyping this evening to figure out the level of difficulty here. From what I can tell, a lot of the details from the Additionally, isort 5 dropped support for python 2.7 and 3.5, so keeping these older Python working is going to take additional complexity to support both ways. Pylint supports both isort 4 and isort 5 with a wrapper class (pylint-dev/pylint#3725) but that usage is less entangled to the isort design and even then some tests are skipped for isort 4. I've pushed the prototype to my fork, at https://github.com/pkolbus/flake8-isort/tree/isort-5 -- will need to put further work on hold for now, but hopefully it helps someone else take it forward. |
I started to work on #92 before I saw your comment, but I basically took the same approach. Tests failed mostly because of the different config file handling, so I adjusted them too. |
Thanks a lot for the discussions and effort! 🙇 I will try to review the PR and get as less in the way as possible 😓 though I will be on vacations for the next 10 days, do my availability will be scarce 😕 |
* Closes #1530 * Clean up some wording and comments * Pin isort version to fix flake8 issue (gforcada/flake8-isort#88)
Hi,
I'm using flake8-isort plugin in my projects and since isort released the new version, v5.0.0, the plugin stopped working.
Here is the log with traceback:
The text was updated successfully, but these errors were encountered: