Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counted in user's response time when timing format conversion #83

Closed
cuihantao opened this issue Jun 5, 2020 · 1 comment
Closed

Counted in user's response time when timing format conversion #83

cuihantao opened this issue Jun 5, 2020 · 1 comment
Assignees
@cuihantao
Labels
bug later low-priority

Comments

@cuihantao
Copy link
Collaborator

When running andes run --convert and the output file exists, the user will be prompted to confirm overwriting. The user's response time is mistakenly counted in the total conversion time.

The timer code is in andes.io.dump(), but the confirmation is called in each converter. We will need to refactor the code and let andes.io.dump() invoke the confirmation.
@cuihantao cuihantao self-assigned this Jun 5, 2020
@cuihantao
Copy link
Collaborator Author

Not planning to fix it since this is really low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuihantao cuihantao

Labels
bug later low-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cuihantao