Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

Frequency-based exact_times = 1 trips must contain trip_id, start_time, and start_date #163

Open
barbeau opened this issue Apr 26, 2017 · 2 comments
Assignees
Labels
new rule your-first-pr Issues that are a good place to start contributing to the project
Milestone

Comments

@barbeau
Copy link
Member

barbeau commented Apr 26, 2017

Summary:

TripDescriptor field must contain trip_id, start_time, and start_date if the trip is defined in GTFS frequencies.txt with exact_times=1. If the TripDescriptor doesn't contain trip_id, start_time, and start_date, this is an error. See https://developers.google.com/transit/gtfs-realtime/reference/TripDescriptor.

Note we have E006 for frequency-based exact_times = 0 trips implemented in FrequencyTypeZeroValidator which is this same concept but for exact_times=0 trips, but I'd prefer to separate these into two different errors to draw out the distinctions for the two types of trips. So, this new rule would be implemented in FrequencyTypeOneValidator, with the unit tests being implemented in FrequencyTypeOneValidatorTest.

@barbeau
Copy link
Member Author

barbeau commented Jul 7, 2017

Here's the commit that added rule E006 (as well as a few other related rules), which is a good reference for what pieces of information (rule, documentation, unit tests) need to be added to the project for each new rule - 51a4d5f. Note that some of this code has since been refactored, so please take a look at the master branch for FrequencyTypeZeroValidator and FrequencyTypeOneValidator to see the most recent version of the code.

@barbeau
Copy link
Member Author

barbeau commented Jul 7, 2017

@Suryakandukoori This is probably a good rule to start on, in terms of implementing new rules for the first time. It mirrors the existing rule E006, but for a different set of trips in a GTFS feed (see above for more info).

Please take a look and let me know if you have any questions.

@barbeau barbeau added this to the v1.0 milestone Jul 7, 2017
@barbeau barbeau assigned barbeau and unassigned Suryakandukoori Sep 1, 2017
@barbeau barbeau modified the milestones: v1.0, v1.1 Mar 9, 2018
@barbeau barbeau added the your-first-pr Issues that are a good place to start contributing to the project label Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new rule your-first-pr Issues that are a good place to start contributing to the project
Projects
None yet
Development

No branches or pull requests

2 participants