Added environment setup for pm.max_children, default:5 #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
djdefi
suggested changes
Mar 9, 2017
conf/.env.docker
Outdated
| @@ -32,3 +32,5 @@ REDIS_PORT="{{REDIS_PORT}}" | |||
| REDIS_PASSWORD="{{REDIS_PASSWORD}}" | |||
|
|
|||
| GITHUB_TOKEN="{{GITHUB_TOKEN}}" | |||
|
|
|||
| MAX_CHILDREN="{{MAX_CHILDREN}}" | |||
There was a problem hiding this comment.
If we need to adjust other NGINX tuning settings in the future , it would be nice to prefix these variables so they are like so: NGINX_MAX_CHILDREN="{{NGINX_MAX_CHILDREN}}"
There was a problem hiding this comment.
I also had the thaughts, but in a sense wouldnt this be part of PHP_ or FPM_?
Or keep it simple and go with NGINX?
There was a problem hiding this comment.
Ah you are right PHP_ would be more appropriate here
|
Renamed it, also removed from .env file since I do not do any sed-ing there |
djdefi
approved these changes
Mar 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.