Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stained glass layered opacity effect only visible at certain angles #1117

Closed
Zeklandia opened this issue Jan 9, 2022 · 4 comments
Closed
Labels
E-duplicate Closed: Duplicate issue T-bug Type: Bug

Comments

@Zeklandia
Copy link

Version information

mc1.18-0.4.0-alpha5+build.9

Expected Behavior

Alternating layers of differently colored stained glass should increase opacity with each layer, eventually becoming opaque.

Actual Behavior

The expected fog effect works in the downward direction, partially in lateral directions, and barely in the vertical direction. It behaves weirdly at chunk and sub-chunk borders, too.

Reproduction Steps

  1. Layer alternating stained glass colors (e.g., lime, yellow, lime, yellow, etc.) in any direction
  2. Look through the stained glass at one end toward the other, perpendicular to the layering

Java version

Java 17.0.1

CPU

AMD Ryzen 9 3000 series

GPU

NVIDIA GeForce RTX 20 series

Additional information

I tested the same location in vanilla and with just Sodium. Adding other mods didn't seem to affect it, including Lithium, Starlight, Iris, and Indium.

Here is the test setup I made with Sodium:
Up:
sodium_up
Down:
sodium_down
North:
sodium_north
East:
sodium_east
South:
sodium_south
West:
sodium_west

And here is the same setup in vanilla 1.18.1:
Up:
vanilla_up
Down:
vanilla_down
North:
vanilla_north
East:
vanilla_east
South:
vanilla_south
West:
vanilla_west

The in-game time was noon for all screenshots.

@Zeklandia Zeklandia added S-needs-triage Status: Needs triage T-bug Type: Bug labels Jan 9, 2022
@Zeklandia
Copy link
Author

Issue #38 seems similar, but I didn't see this specific problem mentioned in the discussions about it.

@Pectacular
Copy link

If you think this issue is similar to #38, shouldn't you mention all of this in that issue?

@Zeklandia
Copy link
Author

I did tag the issue so that this one would get listed there. Since it's just a hunch on my part, I wanted to wait for confirmation from someone who understands how the mod works and the issue at hand.

@LucilleTea
Copy link
Member

Issue #38 is about potentially any case where you see a translucent block through another translucent block (influenced by direction and chunk boundaries), so including this case. This is a very dramatic showcase and I appreciate your work documenting it, more examples aren't necessary from a developer's perspective though. The solution is being worked on in PR #963.

@LucilleTea LucilleTea added E-duplicate Closed: Duplicate issue and removed S-needs-triage Status: Needs triage labels Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-duplicate Closed: Duplicate issue T-bug Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants