Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to ignore server chunk unloading #149

Closed
Khodyn opened this issue Jul 22, 2020 · 6 comments
Closed

Option to ignore server chunk unloading #149

Khodyn opened this issue Jul 22, 2020 · 6 comments
Labels
T-enhancement Type: Enhancement

Comments

@Khodyn
Copy link

Khodyn commented Jul 22, 2020

Right now, if the servers max chunk networking distance is 10 chunks and your render distance is set to 32, it will be as if your render distance was 10. This option would ignore the server unloading chunks on your client, keeping chunks received by the server until they've left your actual render distance.

@Khodyn Khodyn added the T-enhancement Type: Enhancement label Jul 22, 2020
@amnotbananaama
Copy link
Contributor

amnotbananaama commented Jul 22, 2020

See https://bugs.mojang.com/browse/MC-149714 and here for previous discussion on the topic. From Jelly:

My concern would be that it could result in de-sync to old chunks without a lot of special handling.

I would love this, but I'm not sure if it belongs in Sodium. This behavior was present before 1.14.0 in vanilla so it would be great if it could be fixed in vanilla. If Jelly defers this, it would be a great companion mod for Sodium. It shouldn't be too hard to naively implement, just ignore any UnloadChunkS2CPacket packets, with special handling for issues that might crop up.

@Khodyn
Copy link
Author

Khodyn commented Jul 26, 2020

Adding onto this, if this feature were to be added to Sodium it should cache chunks up to twice the render distance away, only rendering them when they come within the normal distance. This is because otherwise if you were to go around loading chunks on a 8-chunk distance server so that you can see a 32x32 area of chunks, you wouldn't be able to load them all without unloading others.

Black pixels: Chunks I want loaded
Blue pixels: Chunks loaded by the server
Red pixels Chunks my client keeps loaded + rendered

chunks

@ghost
Copy link

ghost commented Aug 1, 2020

I have the same issue but I want to lower my render distance cause I lag and I am forced to be using the server's view distance which is terrible..

@MeeniMc
Copy link
Contributor

MeeniMc commented Apr 5, 2021

You could try Bobby
https://github.com/johni0702/bobby

@Redd56
Copy link

Redd56 commented May 15, 2021

You could try Bobby
https://github.com/johni0702/bobby

ill look into this, great to know that the issue is still being thought about tho. atleast in some minor capacity

@mrmangohands
Copy link
Member

As mentioned bobby is an available solution for this, and I think it's probably not within sodium's scope.

embeddedt referenced this issue in FiniteReality/embeddium Aug 28, 2023
Fixes #193 #149 and light for GregTech machines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-enhancement Type: Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants