Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ambient occlusion for blocks whose bottom faces completely cover the underlying block #92

Open
muzikbike opened this issue Jul 15, 2020 · 2 comments
Labels
T-enhancement Type: Enhancement

Comments

@muzikbike
Copy link
Contributor

The following blocks have bottom faces which 100% occlude the block below, yet of all of these, only the solid stone block causes any significant amount of ambient occlusion. The rest should probably be changed to do the same.

2020-07-16_00 21 39
2020-07-16_00 28 04

@MeeniMc
Copy link
Contributor

MeeniMc commented May 11, 2023

Soul-soil blocks now cast ambient occlusion (as of 0.4.10, at least), which is identical to Vanilla. Rest of the proposed blocks still do not (just like vanilla).

@muzikbike
Copy link
Contributor Author

With the fix to #904 eight-layer snow now casts a shadow as expected, but lower layers of snow still don't cast any shadow at all, which I think looks incorrect. I'd expect a shadow that increases in intensity for each layer, starting with barely visible for one layer up to the expected darkness for 8.
2024-05-09_10 19 57

Here's some additional arrangements of snow layers - in each case, the center block is eight layers higher than the surrounding area. We'd therefore expect equal shadow sizes for each case, but that evidently isn't what happens.
2024-05-08_16 15 00
2024-05-09_10 20 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-enhancement Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants