Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually Fix SPIR-V Binding Collisions #13

Closed
CaffeineViking opened this issue Dec 1, 2018 · 1 comment
Closed

Manually Fix SPIR-V Binding Collisions #13

CaffeineViking opened this issue Dec 1, 2018 · 1 comment
Assignees
@CaffeineViking
Labels
Priority: High Project: Renderer Issues relating to the core hair renderer itself. Type: Bug It's not a bug, it's a new feature, I promise! ;-)

Comments

@CaffeineViking
Copy link
Owner

CaffeineViking commented Dec 1, 2018 •
edited

The compute shaders under share/shaders/compute-curve have been converted from HLSL but are still not really valid since they have one / two binding collisions each. I'll sprinkle some [[vk::binding]] directives.
@CaffeineViking CaffeineViking added Type: Bug It's not a bug, it's a new feature, I promise! ;-) Project: Renderer Issues relating to the core hair renderer itself. labels Dec 1, 2018
@CaffeineViking CaffeineViking self-assigned this Dec 1, 2018
@CaffeineViking CaffeineViking mentioned this issue Dec 4, 2018
Closed
6 tasks
@CaffeineViking
Copy link
Owner Author

Fixed the binding collisions I found. The rest we'll find when we try to integrate the compute pass I guess :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CaffeineViking CaffeineViking

Labels
Priority: High Project: Renderer Issues relating to the core hair renderer itself. Type: Bug It's not a bug, it's a new feature, I promise! ;-)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CaffeineViking