Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Files links in entry viewer #66

Open
New0 opened this issue Nov 28, 2017 · 2 comments
Open

Broken Files links in entry viewer #66

New0 opened this issue Nov 28, 2017 · 2 comments

Comments

@New0
Copy link
Contributor

New0 commented Nov 28, 2017

Files attached to a form in a connected form sequence are displayed in the entry viewer with ";} after their name.ext and the link is broken.
That does only happen in connected forms.

Example sent by user : https://prntscr.com/hg2uef ,reproduced and tested in local.

https://secure.helpscout.net/conversation/475889134/6334?folderId=1402017

@New0
Copy link
Contributor Author

New0 commented Jul 5, 2018

Running extended tests I found that saving Advanced file fields in the Connected forms entry (the entry for all forms ) is done with $serialize_arrays set to true at to_array(), l87 classes/object.php whereas for entries of each form of the sequence the Advanced file fields are saved with $serialize_arrays set to false.

That leads to save each file of advanced file fields as a new line in the wp_cf_form_entry_values table for each forms of the sequence when it saves all files as a json object in one line of the wp_cf_form_entry_values table for the connected forms entry.

That explains why the entry viewer doesn't read the data correctly.

I need to find if there is a valid reason why before fixing this, do you have a clue @Shelob9 ?

@Shelob9
Copy link
Contributor

Shelob9 commented Jul 6, 2018

@New0 Good catch.

I need to find if there is a valid reason why
There is no valid reason. Explanation: I did it wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants