Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: boxplot and matrix domain in aggregated scores #208

Merged
merged 1 commit into from
Nov 8, 2022
Merged

fix: boxplot and matrix domain in aggregated scores #208

merged 1 commit into from
Nov 8, 2022

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Nov 7, 2022 •
edited
Loading

Fixes Caleydo/tdp_bi_bioinfodb#1402

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Automatically infer the data domain for boxplot and matrix columns

Screenshots

image

For comparison the same score in Ordino Public:

Image

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@thinkh thinkh added type: bug Something isn't working release: patch PR merge results in a new patch version labels Nov 7, 2022
oltionchampari
oltionchampari approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@oltionchampari oltionchampari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@oltionchampari oltionchampari merged commit 8b2f2a6 into develop Nov 8, 2022
@oltionchampari oltionchampari deleted the thinkh/1402_fix-domain-of-boxplot-matrix-columns branch November 8, 2022 10:41
@dvvanessastoiber dvvanessastoiber mentioned this pull request Nov 23, 2022
Merged
2 tasks
dvvanessastoiber added a commit that referenced this pull request Nov 24, 2022
@dvvanessastoiber @oltionchampari
@thinkh @dvflorianengertsberger
Release 13.0.2 (#210)
8497b68 
* Pass drug screen when multiple data types are selected

* Clean up code

* Add additional depletion screen scores

Caleydo/tdp_bi_bioinfodb#1364

* orphan import

* Linting and other fixes

* Linting

* prepare next development version 12.0.1-SNAPSHOT

* Replace `gene_map_ensgs` with idtype mapping

Closes Caleydo/tdp_bi_bioinfodb#419

* Replace `gene_map_ensgs` request with native idtype mapping
* Remove python DB view
* Remove `_id` from typing, as it was not returned by the API and was not used previously

* Remove orphan import

* Fix typo in depletion screen score name

* Allow for the domain of the scores to be auto-inferred (#175)

Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* Fix Typescript compile errors in `selectionChanged` and `parameterCanged` of ranking views (#191)

* Fix TS errors ranking views

The return value of `selectionChanged` and `parameterCanged` has been typed/changed in datavisyn/tdp_core#725

* Fix data type select in welcome tour (#192)

* Fix outdated dist folder (#194)

* Prepare github changes

* Remove circleci

* prepare next dev version

* Update fontawesome

* refactor: Improve Cypress setup and use Cypress commands.js (#169)

Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* Merge visyn_scripts

* prepare next dev version

* Add nowrap to button, add scrollbar to searchbox (#203)

* Show CoExpression messages / errors (#202)

* Fix sorting of chromosomes due to new typings (#206)

* Fix sorting of chromosomes due to new typings

Caused by datavisyn/tdp_core#794

* Add missing dist files

* prepare next dev version

* Fix score domains (#204)

Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* fix: boxplot and matrix domain in aggregated scores (#208)

Fix boxplot and matrix domain in aggregated scores

Fixes Caleydo/tdp_bi_bioinfodb#1402

* fix: domain of gene signature scores (#209)

Caleydo/tdp_bi_bioinfodb#1402

* fix: rename AVANA to Avana

* prepare release 13.0.2

Co-authored-by: oltionchampari <oltion.champari@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>
Co-authored-by: Champari Oltion <51322092+oltionchampari@users.noreply.github.com>
Co-authored-by: anita-steiner <>
Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
dvvanessastoiber added a commit that referenced this pull request Dec 13, 2022
@dvvanessastoiber @oltionchampari
@thinkh @dvflorianengertsberger
Release 13.0.3 (#211)
6d25fde 
* Pass drug screen when multiple data types are selected

* Clean up code

* Add additional depletion screen scores

Caleydo/tdp_bi_bioinfodb#1364

* orphan import

* Linting and other fixes

* Linting

* prepare next development version 12.0.1-SNAPSHOT

* Replace `gene_map_ensgs` with idtype mapping

Closes Caleydo/tdp_bi_bioinfodb#419

* Replace `gene_map_ensgs` request with native idtype mapping
* Remove python DB view
* Remove `_id` from typing, as it was not returned by the API and was not used previously

* Remove orphan import

* Fix typo in depletion screen score name

* Allow for the domain of the scores to be auto-inferred (#175)

Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* Fix Typescript compile errors in `selectionChanged` and `parameterCanged` of ranking views (#191)

* Fix TS errors ranking views

The return value of `selectionChanged` and `parameterCanged` has been typed/changed in datavisyn/tdp_core#725

* Fix data type select in welcome tour (#192)

* Fix outdated dist folder (#194)

* Prepare github changes

* Remove circleci

* prepare next dev version

* Update fontawesome

* refactor: Improve Cypress setup and use Cypress commands.js (#169)

Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* Merge visyn_scripts

* prepare next dev version

* Add nowrap to button, add scrollbar to searchbox (#203)

* Show CoExpression messages / errors (#202)

* Fix sorting of chromosomes due to new typings (#206)

* Fix sorting of chromosomes due to new typings

Caused by datavisyn/tdp_core#794

* Add missing dist files

* prepare next dev version

* Fix score domains (#204)

Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* fix: boxplot and matrix domain in aggregated scores (#208)

Fix boxplot and matrix domain in aggregated scores

Fixes Caleydo/tdp_bi_bioinfodb#1402

* fix: domain of gene signature scores (#209)

Caleydo/tdp_bi_bioinfodb#1402

* fix: rename AVANA to Avana

* prepare next dev version

* add: missing dist files

* prepare release 13.0.3

Co-authored-by: oltionchampari <oltion.champari@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>
Co-authored-by: Champari Oltion <51322092+oltionchampari@users.noreply.github.com>
Co-authored-by: anita-steiner <>
Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oltionchampari oltionchampari oltionchampari approved these changes

Assignees

@oltionchampari oltionchampari

Labels
release: patch PR merge results in a new patch version type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thinkh @oltionchampari