-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show CoExpression messages / errors #202
Merged
thinkh
merged 2 commits into
develop
from
och/1391-coexpression-single-selection-message
Sep 29, 2022
Merged
Show CoExpression messages / errors #202
thinkh
merged 2 commits into
develop
from
och/1391-coexpression-single-selection-message
Sep 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oltionchampari
added
type: bug
Something isn't working
release: minor
PR merge results in a new minor version
labels
Sep 28, 2022
oltionchampari
changed the title
Och/1391 coexpression single selection message
Show CoExpression messages / errors
Sep 28, 2022
thinkh
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Works as expected. 👍
ghost
pushed a commit
that referenced
this pull request
Sep 30, 2022
* Pass drug screen when multiple data types are selected * Clean up code * Add additional depletion screen scores Caleydo/tdp_bi_bioinfodb#1364 * orphan import * Linting and other fixes * Linting * prepare next development version 12.0.1-SNAPSHOT * Replace `gene_map_ensgs` with idtype mapping Closes Caleydo/tdp_bi_bioinfodb#419 * Replace `gene_map_ensgs` request with native idtype mapping * Remove python DB view * Remove `_id` from typing, as it was not returned by the API and was not used previously * Remove orphan import * Fix typo in depletion screen score name * Allow for the domain of the scores to be auto-inferred (#175) Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> * Fix Typescript compile errors in `selectionChanged` and `parameterCanged` of ranking views (#191) * Fix TS errors ranking views The return value of `selectionChanged` and `parameterCanged` has been typed/changed in datavisyn/tdp_core#725 * Fix data type select in welcome tour (#192) * Fix outdated dist folder (#194) * Prepare github changes * Remove circleci * prepare next dev version * Update fontawesome * refactor: Improve Cypress setup and use Cypress commands.js (#169) Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io> Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> * Merge visyn_scripts * prepare next dev version * Add nowrap to button, add scrollbar to searchbox (#203) * Show CoExpression messages / errors (#202) * prepare release 13.0.1 * Fix sorting of chromosomes due to new typings (#206) * Fix sorting of chromosomes due to new typings Caused by datavisyn/tdp_core#794 * Add missing dist files Co-authored-by: oltionchampari <oltion.champari@datavisyn.io> Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> Co-authored-by: Champari Oltion <51322092+oltionchampari@users.noreply.github.com> Co-authored-by: anita-steiner <> Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
dvvanessastoiber
added a commit
that referenced
this pull request
Nov 24, 2022
* Pass drug screen when multiple data types are selected * Clean up code * Add additional depletion screen scores Caleydo/tdp_bi_bioinfodb#1364 * orphan import * Linting and other fixes * Linting * prepare next development version 12.0.1-SNAPSHOT * Replace `gene_map_ensgs` with idtype mapping Closes Caleydo/tdp_bi_bioinfodb#419 * Replace `gene_map_ensgs` request with native idtype mapping * Remove python DB view * Remove `_id` from typing, as it was not returned by the API and was not used previously * Remove orphan import * Fix typo in depletion screen score name * Allow for the domain of the scores to be auto-inferred (#175) Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> * Fix Typescript compile errors in `selectionChanged` and `parameterCanged` of ranking views (#191) * Fix TS errors ranking views The return value of `selectionChanged` and `parameterCanged` has been typed/changed in datavisyn/tdp_core#725 * Fix data type select in welcome tour (#192) * Fix outdated dist folder (#194) * Prepare github changes * Remove circleci * prepare next dev version * Update fontawesome * refactor: Improve Cypress setup and use Cypress commands.js (#169) Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io> Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> * Merge visyn_scripts * prepare next dev version * Add nowrap to button, add scrollbar to searchbox (#203) * Show CoExpression messages / errors (#202) * Fix sorting of chromosomes due to new typings (#206) * Fix sorting of chromosomes due to new typings Caused by datavisyn/tdp_core#794 * Add missing dist files * prepare next dev version * Fix score domains (#204) Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> * fix: boxplot and matrix domain in aggregated scores (#208) Fix boxplot and matrix domain in aggregated scores Fixes Caleydo/tdp_bi_bioinfodb#1402 * fix: domain of gene signature scores (#209) Caleydo/tdp_bi_bioinfodb#1402 * fix: rename AVANA to Avana * prepare release 13.0.2 Co-authored-by: oltionchampari <oltion.champari@datavisyn.io> Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> Co-authored-by: Champari Oltion <51322092+oltionchampari@users.noreply.github.com> Co-authored-by: anita-steiner <> Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
dvvanessastoiber
added a commit
that referenced
this pull request
Dec 13, 2022
* Pass drug screen when multiple data types are selected * Clean up code * Add additional depletion screen scores Caleydo/tdp_bi_bioinfodb#1364 * orphan import * Linting and other fixes * Linting * prepare next development version 12.0.1-SNAPSHOT * Replace `gene_map_ensgs` with idtype mapping Closes Caleydo/tdp_bi_bioinfodb#419 * Replace `gene_map_ensgs` request with native idtype mapping * Remove python DB view * Remove `_id` from typing, as it was not returned by the API and was not used previously * Remove orphan import * Fix typo in depletion screen score name * Allow for the domain of the scores to be auto-inferred (#175) Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> * Fix Typescript compile errors in `selectionChanged` and `parameterCanged` of ranking views (#191) * Fix TS errors ranking views The return value of `selectionChanged` and `parameterCanged` has been typed/changed in datavisyn/tdp_core#725 * Fix data type select in welcome tour (#192) * Fix outdated dist folder (#194) * Prepare github changes * Remove circleci * prepare next dev version * Update fontawesome * refactor: Improve Cypress setup and use Cypress commands.js (#169) Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io> Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> * Merge visyn_scripts * prepare next dev version * Add nowrap to button, add scrollbar to searchbox (#203) * Show CoExpression messages / errors (#202) * Fix sorting of chromosomes due to new typings (#206) * Fix sorting of chromosomes due to new typings Caused by datavisyn/tdp_core#794 * Add missing dist files * prepare next dev version * Fix score domains (#204) Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> * fix: boxplot and matrix domain in aggregated scores (#208) Fix boxplot and matrix domain in aggregated scores Fixes Caleydo/tdp_bi_bioinfodb#1402 * fix: domain of gene signature scores (#209) Caleydo/tdp_bi_bioinfodb#1402 * fix: rename AVANA to Avana * prepare next dev version * add: missing dist files * prepare release 13.0.3 Co-authored-by: oltionchampari <oltion.champari@datavisyn.io> Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> Co-authored-by: Champari Oltion <51322092+oltionchampari@users.noreply.github.com> Co-authored-by: anita-steiner <> Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Caleydo/tdp_bi_bioinfodb/issues/1391
Developer Checklist (Definition of Done)
Issue
UI/UX/Vis
Code
PR
release: minor
) to this PR following semverCloses #...
)Summary of changes
element.attr(hidden, false)
. That usually works, but bootstrap adds thestyle
in it's
_reboot.scss
file (tourdino does the same which is redundant _global.scss)This probably used to work in an earlier version of bootstrap but changed with B5
The correct way is
element.attr(hidden, null)
which removes the attribute. This is what we do in the core when using the hidden attributealert warning
for the selection message and the no data found message.Screenshots