Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.9 Fix tree node locator to work with umlauts correctly #28

Open
wants to merge 1 commit into
base: 6.9
Choose a base branch
from

Conversation

mugge6
Copy link
Member

@mugge6 mugge6 commented Apr 17, 2024

Tree node locator is comparing always the first and last child element with the current node to decide if the requested item was found on the current page. If there is a umlaut (äöü) on the key this doesn't work, because a simple comparison with < or > is based on their ASCI code. This fix will replace the comparison with the localeCompare function.

This fix should be contributed to Pimcore as soon as Cando will support one of the current versions from Pimcore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant