Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EDITOR and PAGER environment variables to edit and view respectively #20

Closed
zummenix opened this issue Feb 4, 2019 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@zummenix
Copy link

zummenix commented Feb 4, 2019

Currently, broot creates a config file with edit and view tools predefined. I think, for most users the default/expected behaviour would be to use tools set in EDITOR (with fallback to vi?) and PAGER (with fallback to less?) environment variables.

@Canop
Copy link
Owner

Canop commented Feb 4, 2019

The problem is not so many users have those variables defined, which means you need to ask users to define an editor in the config anyway. I didn't see any obvious way to make that clear for users.

Even xdg-open is rarely very relevant.

@zummenix
Copy link
Author

zummenix commented Feb 5, 2019

To clarify, the behavior I'm talking about is: when invoking an edit use tool defined in config; if not defined, fallback to EDITOR; if the variable is not set, fallback to vim. The same for open. I don't think it requires more explanation in the docs.

P.S: with current defaults edit doesn't work for me, because I have neovim installed in another path.

@Canop Canop added the enhancement New feature or request label Feb 12, 2019
@Canop Canop self-assigned this Feb 12, 2019
lovasoa added a commit to lovasoa/broot that referenced this issue Mar 12, 2019
lovasoa added a commit to lovasoa/broot that referenced this issue Mar 12, 2019
lovasoa added a commit to lovasoa/broot that referenced this issue Mar 12, 2019
@Canop Canop closed this as completed in 7461f47 Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants