Allow environment variables in verbs #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Canop : What do you think ? |
|
I'm not 100% sure it's the right approach but I'll probably merge it as it seems innocuous. |
|
Yes, allowing reference to environment variables in verbs allows better configurability, but it still does not fully solve #20, as it does not provide a fallback editor. |
|
Anyway, it should be more widely compatible than the current hard reference to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new feature that I find useful: environment variables in verbs.
This allows verbs to reference environment variables.
Instead of hard coding
/usr/bin/nvim {file}, one can now write$EDITOR {file}. It will open the file in the default editor.See #20