-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't count hidden special paths when computing dir sizes #331
Comments
Just a thought, if this is proving a challenge to implement, maybe don't compute and display overall size whilst in whale-spotting mode? That would be circled item in this screenshot: Or maybe provide a flag to disable it? As noted in #330, the addition of that size heading slowed down my whale-spotting by about 50x due to a large and slow encrypted CIFS network directory in my home (via PAM mount). Cheers. |
The problem isn't really the total size of the root, because you'd have to compute the size of I'll test and see the impact on performances. |
The impact on performance will vary depending on the size and speed of the hidden directories. I only whale spot in my home directory. In my case the encrypted CIFS volume that I mount in my home directory runs about 4 times slower than a traditional spinning hard disk (network speed loss and decryption-in-NAS loss). About 28MB/s max (often slower than that). It is about 1.5TB in size. I don't want whale spotting to look at this directory at all, it is big and ridiculously slow. Version 1.0.7 computed whale-spotting for my home directory in about 4 or 5 seconds. Version 1.0.8 takes about 90 - 120 seconds, related to that top-left size indicator walking the NAS (which I can hear crunching). Hidden directories are bad news. Cheers. |
I've pushed the change but it can still be considered a little experimental and isn't 100% sure to find its way to the next release. I'd like confirmation it's OK. |
It's now in broot v1.2.2 |
I greatly appreciate that @Canop. Best regards. |
Summary: update broot to latest upstream release Changelog: - special paths in "no-enter" or "hide" aren't counted when summing sizes or dates. It's a compromise: it makes all sums a little slower, especially if you have a lot of special paths or complex ones, but it allows skipping over the very slow disks and thus makes some cases much faster - Fix [#331](Canop/broot#331) - br fish shell function uses shell completion of broot - tree height in `:pt` now applies even when there are more root items (thus truncating the tree) - Fix [#341](Canop/broot#341) - fix the F5 and F6 shortcuts (copy and move between panels) in the default configuration Test Plan: - install br function - run br in multiple directories - open files using the explorer - search for files using the explorer - navigate directories using the explorer Reviewers: #triage_team, JoshStrobl Reviewed By: #triage_team, JoshStrobl Subscribers: JoshStrobl, sethfl Differential Revision: https://dev.getsol.us/D10496
There's a good example in this issue: #330
What's required here is to not take into account the hidden directories when computing sizes.
The text was updated successfully, but these errors were encountered: