Don't count hidden special paths when computing dir sizes

[Canop]

There's a good example in this issue: #330

What's required here is to not take into account the hidden directories when computing sizes.

[bluz71]

Just a thought, if this is proving a challenge to implement, maybe don't compute and display overall size whilst in whale-spotting mode? That would be circled item in this screenshot:

Or maybe provide a flag to disable it?

As noted in #330, the addition of that size heading slowed down my whale-spotting by about 50x due to a large and slow encrypted CIFS network directory in my home (via PAM mount).

Cheers.

[Canop]

The problem isn't really the total size of the root, because you'd have to compute the size of /home/dennis when looking at / anyway. There no really any other solution than to check for all subpath, while walking the tree, whether it's a special path.

I'll test and see the impact on performances.

[bluz71]

The impact on performance will vary depending on the size and speed of the hidden directories. I only whale spot in my home directory.

In my case the encrypted CIFS volume that I mount in my home directory runs about 4 times slower than a traditional spinning hard disk (network speed loss and decryption-in-NAS loss). About 28MB/s max (often slower than that).

It is about 1.5TB in size. I don't want whale spotting to look at this directory at all, it is big and ridiculously slow.

Version 1.0.7 computed whale-spotting for my home directory in about 4 or 5 seconds.

Version 1.0.8 takes about 90 - 120 seconds, related to that top-left size indicator walking the NAS (which I can hear crunching).

Hidden directories are bad news.

Cheers.

[Canop]

I've pushed the change but it can still be considered a little experimental and isn't 100% sure to find its way to the next release.

I'd like confirmation it's OK.

[bluz71]

@Canop,

I built broot with your recent commit de3e312.

Excellent, it solves the issue. Runs very fast, like 1.0.7, by ignoring my slow-duper NAS drive.

Looks great to me. Many thanks.

P.S. I hope you include this.

[Canop]

It's now in broot v1.2.2

[bluz71]

I greatly appreciate that @Canop.

Best regards.