Implement #140 and #169 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 12, 2023
riderx
reviewed
Oct 12, 2023
src/index.ts
Outdated
| @@ -138,6 +139,14 @@ bundle | |||
| .action(listBundle) | |||
| .option('-a, --apikey <apikey>', 'apikey to link to your account'); | |||
|
|
|||
| bundle | |||
| .command('current [channel]') | |||
There was a problem hiding this comment.
Since we get the bundle of a channel, I would maybe add this command to channel instead
|
i believe a branch a bounty is better even for review. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/approve 140 |
|
@riderx: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment. |
|
/approve 169 |
|
@riderx: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new commands are:
As for tests: If needed I can implement them later. @riderx let me know if you want tests for this.
Also my changes do not break any existing command. I checked, they are backward compatible
Here is a showcase of my changes:
/claim #140
/claim #169