Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide recording window when recording, and create tray icon (macOS) #21

Closed
richiemcilroy opened this issue Apr 5, 2024 · 30 comments
Closed
Labels
good first issue Good for newcomers help wanted Extra attention is needed 💰 Rewarded

Comments

@richiemcilroy
Copy link
Contributor

richiemcilroy commented Apr 5, 2024

On starting recording, hide the main Cap window.

Show a stop recording icon in the macOS menu bar tray.

On tray icon click, stop the recording.

This is currently required for macOS only.

Requirements
-Create menu bar tray icon. Use Cap logo as icon maybe? This can be changed later.
-When recording is active, change icon to a stop icon. Maybe use this icon from Lucide.
-When recording is active, hide main Cap app recording window (keep camera overlay window as it is)

You can use this guide to help you get started developing locally as quickly as possible.

@richiemcilroy richiemcilroy added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 5, 2024
@richiemcilroy
Copy link
Contributor Author

/bounty $50

@syedbarimanjan
Copy link

syedbarimanjan commented Apr 6, 2024

can you assign this to me.
/attempt #21

@syedbarimanjan
Copy link

This is all needed on mac maybe you should add a label "mac" on it @richiemcilroy.

@richiemcilroy richiemcilroy changed the title Hide recording window when recording, and create tray icon Hide recording window when recording, and create tray icon (macOS) Apr 6, 2024
@richiemcilroy
Copy link
Contributor Author

@syedbarimanjan done!

@Om-jannu
Copy link

Om-jannu commented Apr 6, 2024

/attempt #21

@richiemcilroy
Copy link
Contributor Author

Anyone have a WIP for this?

@syedbarimanjan
Copy link

syedbarimanjan commented Apr 8, 2024

Anyone have a WIP for this?

I am working on it, will raise the pr.

@richiemcilroy
Copy link
Contributor Author

/bounty $150

@richiemcilroy
Copy link
Contributor Author

Upped the bounty to $150.

@lukasgjetting
Copy link

In case it's helpful to anyone: I've set up a wip here.

Still missing a few things:

  1. Tray should only be initialized on MacOS
  2. Clicking tray icon to stop recording doesn't sync the UI
  3. Doesn't respect the same "min 5 sec" rule as the frontend (maybe it shouldn't?)
  4. Haven't tested outside local mode, but based on the logging it seems to work correctly

@ItsEeleeya
Copy link
Contributor

All requirements added here

There's a quit and a dedicated show button. Left clicking the tray icon shows the main window as well.
Tray icon changes when you start or stop the recording.
When recording starts all windows except camera view get hidden.
Since handling the tray click event is done in the frontend, the UI reacts correctly.

I'm hoping later I can add the camera and microphone selectors to the tray menu as well.

Cap Tray

@richiemcilroy
Copy link
Contributor Author

All requirements added here

There's a quit and a dedicated show button. Left clicking the tray icon shows the main window as well.

Tray icon changes when you start or stop the recording.

When recording starts all windows except camera view get hidden.

Since handling the tray click event is done in the frontend, the UI reacts correctly.

I'm hoping later I can add the camera and microphone selectors to the tray menu as well.

Cap Tray

Nice @ItsEeleeya - I'll check when I get to my desktop. If you add the mic / camera selectors there I'll add another $50 to the bounty

@ItsEeleeya
Copy link
Contributor

Nice @ItsEeleeya - I'll check when I get to my desktop. If you add the mic / camera selectors there I'll add another $50 to the bounty

If there are no problems with the current features then that'll probably be for tomorrow!

@jemiluv8
Copy link

@ItsEeleeya I'd suggest you create a draft PR soon. Even with the current version of what you have

@ItsEeleeya
Copy link
Contributor

ItsEeleeya commented Apr 13, 2024

jemiluv8

It doesn't let me open another Pull Request as draft because it's already open

@richiemcilroy could you please turn the pull request to a draft?

@richiemcilroy
Copy link
Contributor Author

Done @ItsEeleeya :)

@richiemcilroy
Copy link
Contributor Author

/bounty $200

@richiemcilroy
Copy link
Contributor Author

Solved with #22

@richiemcilroy
Copy link
Contributor Author

@ItsEeleeya can you create a claim here please?

@ItsEeleeya
Copy link
Contributor

/claim #22

@richiemcilroy
Copy link
Contributor Author

/approve

@richiemcilroy
Copy link
Contributor Author

Sorry @ItsEeleeya it's bugging I think - you may need to do /claim first with the PR linked

Reached out to Algora's support

@ItsEeleeya
Copy link
Contributor

Sorry @ItsEeleeya it's bugging I think - you may need to do /claim first with the PR linked

Reached out to Algora's support

Oh sorry do you mean comment that inside the PR or here? Like <slash>claim #22

@richiemcilroy
Copy link
Contributor Author

/tip $200 @ItsEeleeya

Copy link

algora-pbc bot commented Apr 16, 2024

Copy link

algora-pbc bot commented Apr 16, 2024

@ItsEeleeya: You just got a $200 tip! 👉 Complete your Algora onboarding to collect your payment.

@richiemcilroy
Copy link
Contributor Author

Should be done now @ItsEeleeya :) thanks for your help! feel free to tackle another if you want to claim more

@ItsEeleeya
Copy link
Contributor

Thank you, will do!
I learnt quite a bit of Rust doing this even though I've been making some private and experimental Tauri apps.
It's definitely not priority but I'd like to open some suggestions later on for the UI (the main window frame and design) and a dedicated settings window/view (I think I saw some WIP setting related stuff?).

@ItsEeleeya
Copy link
Contributor

Hey @richiemcilroy
Could you please send me a DM on Twitter? @ItsEeleeya

Copy link

algora-pbc bot commented Apr 27, 2024

🎉🎈 @ItsEeleeya has been awarded $200! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed 💰 Rewarded
Projects
None yet
Development

No branches or pull requests

6 participants