-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macos tray icon #22
Macos tray icon #22
Conversation
Added tray menu icon Icon changes when recording starts or stops When icon is clicked the window gets focus
Make all windows hide when recording stops. Implement the tray "Show Cap" button
@ItsEeleeya is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Hey @ItsEeleeya - it's looking good! Almost there. However when I begin the recording the tray icon doesn't seem to change. |
Hey, I checked this before pushing and it was working Now that I try building or running dev it either complains about resend api key not being there, or get a bunch of Next.js errors. (Tried deleting everything and pulling from commits, same results) |
Hmm if you go to Privacy & Security - do you have permissions enabled for the Terminal app for Screen Recording, Microphone, Camera? I'll add this to the guide. Let me know if that stops some of the errors |
The minimum 5 second length wasn't seem to be respected after your first recording in the latest version. The tray icon should now change more consistently
I changed where it triggers and fixed a small problem. One small note, sometimes the app crashes on stop recording when whether I'm on this or the main branch but not the latest release. Is this known? |
Not yet functional
Hey @ItsEeleeya - is this ready for me to re-review? |
For the tray icon, Yes. It is nearly finished except for some UI de-sync that can happen |
Known issue: Selecting None for video input can result in de-sync and instead select the first real device.
…areas Frontend media device pickers now sync with the tray device picker. Rename Devices to Device. Rename Device.deviceId to Device.id Refactor Recorder.handleContextClick
Hey @richiemcilroy |
Hey @ItsEeleeya - works great! Only problem I can see is that the recording icon doesn't change to the stop icon when recording. Below is a screen recording of me starting a Cap recording 771cd745-7e10-427b-94fc-d26f2c15beba.mp4 |
Also thanks for adding the context menu selector to the tray icon - will add $50 to the bounty |
That's odd, it has worked for me since the the first commit and I haven't been able to replicate that. From your video it seems that the icon changes a couple of seconds after stopping the recording which then immediately changes back. Hopefully this will resolve the issue |
Of course! I'd also be happy to help to transition to Tauri v2 once it's stable and there aren't other priority issues that I can work on. |
Solves #21 |
Solves #21