You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🤣 It is so ambiguous everywhere what the max was, especially when I wrote this and had a lot less experience with everyone's implementation (which is the only spec I know). I've updated the code to clarify. I didn't know if the original define (64) was supposed to represent:
The max total packet size. The size of the buffer need to hold an entire CRSF packet including the start byte, len, type, payload and CRC. The payload data is limited to 60 bytes. TRUE
The max total size of everything following the length. FALSE
The max total size of the payload portion, including TYPE, excluding the CRC. FALSE
The max total size of the data portion of the payload, excluding the TYPE and CRC. FALSE
From the TBS spec, "Frame Length: ... Valid range is between 2 and 62 ...".
But:
CRServoF/lib/CrsfSerial/CrsfSerial.cpp
Line 86 in d5e739f
and:
CRServoF/lib/CrsfSerial/crsf_protocol.h
Line 15 in d5e739f
CRSF 'FrameLength' field != CRSF BUFFER SIZE /
CRSF_MAX_PACKET_LEN
.The text was updated successfully, but these errors were encountered: