Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CapMan speed should change based on level #70

Open
jcollard opened this issue Feb 27, 2024 · 2 comments
Open

CapMan speed should change based on level #70

jcollard opened this issue Feb 27, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jcollard
Copy link
Contributor

No description provided.

@jcollard
Copy link
Contributor Author

@DerekGooding My apologies for not describing this enhancement better in this issue.

One thing to consider with this is the way the Player's speed is updated in Pac Man. We did some research on stream and discovered that Pac Man and the Enemies speed are adjusted based on the level (up through level 5). I don't know if we should follow this exactly, but the we implemented a SpeedModifier for EnemyActor. Perhaps this could be moved into the Actor class and used for all actors (including enemies).

This is table shows how the original Pac Man game modifies the speed per level (we don't do anything this sophisticated yet): https://www.designoriented.net/blog/wp-content/uploads/2015/06/img-61.png

Additionally, here is the commit where the SpeedModifier was added to the enemy as well as the relevant tests: 714a1ce

In particular, I think it might be relatively straight forward to move the SpeedModifier property to the parent class / interface, add a new delegate to the SpeedModifiers static class, and set the default for the player to do something similar to the table (does not need to be identical).

@DerekGooding DerekGooding self-assigned this Feb 27, 2024
@DerekGooding
Copy link
Collaborator

Thank you @jcollard.

I've been missing streams. Feels like I need to do a full reread of the codebase every time I jump in. Which I quite enjoy! I'll take these ideas into consideration and work on updating the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants