-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segfault on importing HDR DNG #36
Comments
In the current dev branch (8b84279) it should gracefully fail to import the images; the file will be copied (you don't want to lose it if you're copying from a card!) but it won't be able to generate the thumbnail. I haven't yet sorted out what happens in the Organize view if you attempt to select them; the thumbnail obviously can't load so I need to work out a fallback so that it's at least visible; maybe also have a useful tooltip to tell the user what's going on. |
A placeholder thumbnail saying "Corrupt" or "Unsupported" could be an elegant way out. |
The thumbnail placeholder is feasible, but making it update once the thumbnail is written is harder at the moment. It appears that this is a good opportunity to refactor all of the importing code to be more monolithic. I'll have to make some fairly big changes but on the bright side, I'll have the chance to implement importing without moving the raw (import in place), importing linear tiffs, and perhaps better backup handling. This I'll have to think about for some time, to make sure I make it flexible enough to meet future needs. |
The new LibRaw snapshot apparently supports floating point DNGs. |
Segfault importing this:
http://rawtherapee.com/shared/test_images/hdrmerge_045.dng
Please try the other images from that folder, some of them are (intentionally) corrupt so you will get different kinds of segfaults.
The text was updated successfully, but these errors were encountered: