Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement New Homepage Design #107

Merged
merged 8 commits into from
Oct 10, 2018
Merged

Implement New Homepage Design #107

merged 8 commits into from
Oct 10, 2018

Conversation

vkoves
Copy link
Contributor

@vkoves vkoves commented Sep 26, 2018

Description of Changes:

Restyles the homepage to match the new designs. Here's a screenshot from mobile:

screenshot from 2018-09-25 20-49-57

The layout stays roughly the same on desktop, but a higher quality image is used with less blur, and the sections are larger.

Resolves #73.

Checklist:

  • Code follows code style of this project
  • Tests added to cover changes
  • All new and existing tests passing

Questions / Additional Notes:

Ensured accessibility by using <a> tags for all links and checking contrast on new elements.

@coveralls
Copy link

coveralls commented Sep 26, 2018

Pull Request Test Coverage Report for Build 261

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.143%

Totals Coverage Status
Change from base Build 254: 0.0%
Covered Lines: 102
Relevant Lines: 105

💛 - Coveralls

@SorenSpicknall
Copy link
Collaborator

One note, though I'd like opinions on whether this is easily addressed or worth addressing right now. At medium screen sizes (like a small tablet or a huge phone), the "Report An Issue" text intersects with the image above it. It's probably an edge case because not many devices are at this width, but is a bug.

text overlap

@vkoves
Copy link
Contributor Author

vkoves commented Oct 3, 2018

Good catch @AcademyInPeril, I've updated the PR.

@vkoves vkoves modified the milestone: Minimum Viable Product Oct 10, 2018
Copy link
Collaborator

@SorenSpicknall SorenSpicknall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! It looks like it works much more smoothly right now on my broswers.

@vkoves vkoves merged commit 2929bf0 into master Oct 10, 2018
@vkoves vkoves deleted the implement-homepage branch October 10, 2018 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants