-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check out dependencies specified in Cartfile #7
Comments
Should this be |
I like |
We could put this in the project's derived data.
|
I personally clean my |
Run script phases & other things frequently mash around in there, so we’d want to avoid collisions. |
I'm currently leaning toward storing these checkouts within the repository itself, to allow users to commit them if they want to. Similarly, I don't think So, maybe we can create a bare clone in a private, global folder (a la Cabal), and checkout that clone into the repository folder? |
I was going suggest that we store them as submodules and let the user specify which directory the go in. I don't understand the points you're trying to make here. |
Sorta like |
@mdiep My point is, if you want to commit your dependencies into your repository to prevent them from disappearing (which is especially important for consulting), submodules aren't an option, because they rely upon an external reference remaining valid. If, however, we allow them to commit the content of dependencies, they'll at least have the code if the repositories go AWOL.
@robrix I guess, but the difference is that we can share Git clones with multiple Carthage projects if we centralize some bare clones, and then simply |
Ugh. I really hate that. Diffs get nasty. You lose the niceness of submodules on .com. If you want to make sure the references remain valid, you should fork it or keep a copy somewhere. |
If you don't want to commit your dependencies, you can just
The Carthagespec diff is what's canonical anyways, so it seems like submodule diffs would just be distraction/duplication. |
Except it's "hard" to go from a carthagespec to browsing the repository/tree. And I'm hoping that submodule diffs will someday link to a compare view. |
👍 |
I might take stab at this... :) |
Set up Travis CI
Caching improvements
We should clone dependencies—and their dependencies’ dependencies—while trying to find the versions of everything that match what's specified in the config.
Where would these checkouts live? A global folder, or something inside the repository? The latter could be useful if you want to commit your dependencies (to protect against them disappearing).
The text was updated successfully, but these errors were encountered: