Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable icon styling with categories #11019

Closed
javierarce opened this issue Dec 12, 2016 · 8 comments
Closed

Enable icon styling with categories #11019

javierarce opened this issue Dec 12, 2016 · 8 comments

Comments

@javierarce
Copy link
Contributor

javierarce commented Dec 12, 2016

Extend the icon styling feature to support adding an icon to each category.

Creating a category icon map would be possible by choosing the BY VALUE option when clicking on the color input. If selecting an string column, the UI will offer different buttons to assign an icon to every category (remember we give 10 results as max).

This functionality will let the user to select an icon and a color - if the icon format is svg - for every category plus a style for the OTHERS category in case it exist.

See the discussion for the workflow and design for this feature in this ticket. Final design is here

Contact @urbanphes or @javierarce if you have doubts with the workflow or design of this feature.

The current icon styling feature is hidden with a feature flag. Once this ticket is completed, talk to @javierarce or @xavijam to enable this feature to everybody.

@javierarce javierarce changed the title Enable icon styling with categories Enable icon styling with categories [BLOCKED by #10746] Dec 12, 2016
@xavijam xavijam changed the title Enable icon styling with categories [BLOCKED by #10746] Enable icon styling with categories Dec 14, 2016
@xavijam xavijam removed the blocked label Dec 14, 2016
@MariaCheca MariaCheca self-assigned this Dec 14, 2016
@xavijam xavijam modified the milestone: Style with icons Dec 14, 2016
@ivanmalagon ivanmalagon removed their assignment Dec 27, 2016
@jorgesancha
Copy link
Contributor

Style With Icons

@javierarce
Copy link
Contributor Author

Moving this back to development so we can fix the problems found in the CR here

@MariaCheca
Copy link
Contributor

I'll take care of it asap.

@jorgesancha
Copy link
Contributor

very thorough CR @javierarce 👏 👏

@MariaCheca MariaCheca self-assigned this Jan 9, 2017
@saleiva saleiva removed the Next label Jan 10, 2017
@MariaCheca MariaCheca removed their assignment Jan 10, 2017
@javierarce javierarce assigned javierarce and unassigned javierarce Jan 10, 2017
@javierarce javierarce removed their assignment Jan 11, 2017
@MariaCheca MariaCheca removed their assignment Jan 11, 2017
@nobuti nobuti assigned nobuti and MariaCheca and unassigned nobuti Jan 11, 2017
@MariaCheca MariaCheca removed their assignment Jan 12, 2017
@nobuti nobuti assigned nobuti and MariaCheca and unassigned nobuti Jan 12, 2017
@MariaCheca MariaCheca removed their assignment Jan 12, 2017
@gfiorav gfiorav assigned gfiorav and MariaCheca and unassigned gfiorav Jan 12, 2017
@MariaCheca MariaCheca removed their assignment Jan 12, 2017
@javitonino javitonino assigned javitonino and unassigned javitonino Jan 12, 2017
@MariaCheca MariaCheca assigned MariaCheca and unassigned MariaCheca Jan 12, 2017
@nobuti
Copy link
Contributor

nobuti commented Jan 13, 2017

Back to acceptance.

@juanignaciosl juanignaciosl self-assigned this Jan 13, 2017
@MariaCheca
Copy link
Contributor

Deployed in ded04, ready to test!

@jorgesancha
Copy link
Contributor

jorgesancha commented Jan 13, 2017 via email

@juanignaciosl
Copy link
Contributor

For the record, I'm testing in ded06 because I triggered the deployment before and we agreed upon deployment being done by the one who accepts ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants