Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Extra API call in global search #14774

Closed
gonzaloriestra opened this issue Mar 26, 2019 · 1 comment
Closed

[Dashboard] Extra API call in global search #14774

gonzaloriestra opened this issue Mar 26, 2019 · 1 comment
Assignees
@jesusbotella
Labels
Frontend

Comments

@gonzaloriestra
Copy link
Contributor

Steps to Reproduce

  1. Go to the global search in the dashboard
  2. Write something and press enter quickly (without waiting for the preview)

Current Result

It makes 3 API calls:

  • Map search
  • Dataset search
  • Map/dataset search (preview) with an empty pattern: api/v1/viz//?types=derived%2Ctable&per_page=4&q=

Expected result

Only 2 API calls, for map and dataset search.

@CartoDB/rt-managers
@jesusbotella jesusbotella self-assigned this Mar 27, 2019
@jesusbotella jesusbotella mentioned this issue Mar 27, 2019
Merged
@jesusbotella
Copy link
Contributor

Merged and deployed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jesusbotella jesusbotella

Labels
Frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jesusbotella @gonzaloriestra