Update browserify #2449
Merged
Update browserify #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
Frontend tests were OK 👍 (details) |
|
retest this please |
|
Frontend tests were OK 👍 (details) |
added 5 commits
February 23, 2015 18:41
Fixates version to only update to minor updates
|
Frontend tests were OK 👍 (details) |
|
retest this please |
|
Frontend tests were OK 👍 (details) |
|
retest this please |
|
Frontend tests were OK 👍 (details) |
|
retest this please |
|
Frontend tests were OK 👍 (details) |
|
retest this please |
|
Frontend tests were OK 👍 (details) |
|
@xavijam seems we have a winner, I'll merge tomorrow, ok? |
|
ok! 💃 |
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
|
@CartoDB/frontend FYI, this should fix the broken builds on clinker (all builds in this PR have worked fine and tested deploy on staging). read PR desc for info |
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2447
Ditch
remapify(in favor of default, relative, requires), since the author don't seem to have time to keep it up-to-date with browserify (and we don't either). This allows us to also update to latest version of browserify that don't seem to have this issue, and also contain quite a lot of fixes.Considering we are a few touching these files and the changes are only for the require calls I don't expect much problems upon updating to master in existing dev branches.
Will re-run clinker a few times to make sure there are no more failures before merging.