-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browserify #2449
Update browserify #2449
Conversation
retest this please |
Frontend tests were OK 👍 (details) |
retest this please |
Frontend tests were OK 👍 (details) |
Fixates version to only update to minor updates
Frontend tests were OK 👍 (details) |
retest this please |
Frontend tests were OK 👍 (details) |
retest this please |
Frontend tests were OK 👍 (details) |
retest this please |
Frontend tests were OK 👍 (details) |
retest this please |
Frontend tests were OK 👍 (details) |
@xavijam seems we have a winner, I'll merge tomorrow, ok? |
ok! 💃 |
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
@CartoDB/frontend FYI, this should fix the broken builds on clinker (all builds in this PR have worked fine and tested deploy on staging). read PR desc for info |
💃 |
Fixes #2447
Ditch
remapify
(in favor of default, relative, requires), since the author don't seem to have time to keep it up-to-date with browserify (and we don't either). This allows us to also update to latest version of browserify that don't seem to have this issue, and also contain quite a lot of fixes.Considering we are a few touching these files and the changes are only for the require calls I don't expect much problems upon updating to master in existing dev branches.
Will re-run clinker a few times to make sure there are no more failures before merging.