Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failing due to browserify on clinker #2447

Closed
viddo opened this issue Feb 23, 2015 · 1 comment · Fixed by #2449
Closed

Build failing due to browserify on clinker #2447

viddo opened this issue Feb 23, 2015 · 1 comment · Fixed by #2449
Assignees

Comments

@viddo
Copy link
Contributor

viddo commented Feb 23, 2015

Last case on clinker failing

...
Running "browserify:new_dashboard" (browserify) task
00:01:30.649 >> Error: Cannot find module 'new_dashboard/router' from '/home/administrador/jenkins/workspace/CartoDB-PR-testing/lib/assets/javascripts/cartodb/new_dashboard'
00:01:30.651 Warning: Error running grunt-browserify. Use --force to continue.
00:01:30.652 
00:01:30.653 Aborted due to warnings.
00:01:30.661 make: *** [check-frontend] Error 6
00:01:30.678 Build step 'Execute shell' marked build as failure
...

However, the file do exist and re-trigger a build seems to fix it on clinker. So far only @xavijam have been able to reproduce it locally, and fixed by re-installing npm packages (i.e. deleting node_modules dir and run npm install). Unfortunately he doesn't have a backup of that dir so we could do a diff to see what changed.

@viddo
Copy link
Contributor Author

viddo commented Feb 23, 2015

My guess right now is that something got changed in some browserify-related package which we have installed locally but which is not installed on clinker. I'll try to update the browserify version we have set right now and see fi I can provoke this on a PR (we'll need to update sooner or later anyway so might as well do it now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants