3879 new named maps fields #3974
Conversation
Conflicts: app/models/visualization/member.rb services/named-maps-api-wrapper/lib/named-maps-wrapper/named_map.rb
| @@ -137,6 +137,7 @@ def qualified_name(viewer_user=nil) | |||
| end | |||
| end | |||
|
|
|||
| # Despite storing always a named map, no need to retrievfe it for "public" visualizations | |||
| end | ||
|
|
||
| data = { | ||
| zoom: visualization.map.zoom, |
There was a problem hiding this comment.
This method has too many visualization.map.whatever. Delegation (visualization.whatever) is not a good solution here, but probably you could move most of the method (or all) to Map and use self instead of receiving an object.
|
As I've said in the comments, I'd move many of class method |
|
Agreed on moving to 'Map' this methods, they are still ugly as hell but now is not the time to refactor how Map attributes are stored so convenience methods will do 👍 Presenters I don't like because the issue is that right now stored Map attributes are suboptimal (a string), where it should have real numbers and if something, have a presenter add the string version (but here I don't see it as is just the same data inside an array). |
No description provided.