Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a named map for every single visualization #3879

Closed
9 tasks done
javisantana opened this issue Jun 1, 2015 · 3 comments
Closed
9 tasks done

create a named map for every single visualization #3879

javisantana opened this issue Jun 1, 2015 · 3 comments
Assignees
Labels

Comments

@javisantana
Copy link
Contributor

Details by @Kartones:

Tasks

  • Store named maps for all types of vis, public or private #3918
  • Migrate existing vis so all have named maps #3918 #3954 (needs release of branch 3879-improved-script and run cartodb:vizs:create_named_maps rake). <- Last 11k failed (out of 374k)
  • Remove checks of "has named map" etc. and simplify code
  • Add new fields required for static maps:
  • Add to named map basemap layer ('http') (doc)
  • Add bounding box to named map ("view" layer, doc).
  • Tests for newly added fields
  • Migrate to add values for existing named maps (no need for new script, just re-running existing one)
  • Relax naming restraints of templates (see Windshaft part)
  • Migrate existing template names? duplicate them? (needs planning after previous point is done)

Branches

  • 3879-named-maps-everywhere
  • 3879-improved-script
  • 3879-clean-named-maps-checks
  • 3879-new-named-maps-fields (PR, needs reverting)

Description (original by @javisantana )

so we can generate previews for all the visualizations:

http://...../named/e1986900-cd40-11e4-b81f-0e43f3deba5a/width/height.png

this also needs a task to update all the current maps so:

  • include the basemap
  • include the map view bounds information

@rochoa will point here to the documentation

@javisantana javisantana added this to the Castrillo milestone Jun 1, 2015
@rochoa
Copy link
Contributor

rochoa commented Jun 1, 2015

Some examples about what we need/want can be found in the official documentation: http://docs.cartodb.com/cartodb-platform/maps-api.html#examples

Names for the named maps / templates right now are limited to: Valid names start with a letter, and only contain letters, numbers, or underscores (_). http://docs.cartodb.com/cartodb-platform/maps-api.html#arguments
Probably we want to change that so we don't have to do any workaround like name = 'tpl_' viz.id.replace('-', '_') as we do now., don't we?

Kartones pushed a commit that referenced this issue Jun 3, 2015
Kartones pushed a commit that referenced this issue Jun 4, 2015
Kartones pushed a commit that referenced this issue Jun 4, 2015
Kartones pushed a commit that referenced this issue Jun 4, 2015
Kartones pushed a commit that referenced this issue Jun 4, 2015
Kartones pushed a commit that referenced this issue Jun 4, 2015
Kartones pushed a commit that referenced this issue Jun 4, 2015
Kartones pushed a commit that referenced this issue Jun 5, 2015
Kartones pushed a commit that referenced this issue Jun 5, 2015
Kartones pushed a commit that referenced this issue Jun 5, 2015
Kartones pushed a commit that referenced this issue Jun 7, 2015
Kartones pushed a commit that referenced this issue Jun 7, 2015
Kartones added a commit that referenced this issue Jun 8, 2015
Kartones pushed a commit that referenced this issue Jun 8, 2015
Kartones pushed a commit that referenced this issue Jun 8, 2015
Kartones pushed a commit that referenced this issue Jun 8, 2015
@javisantana
Copy link
Contributor Author

\o/

@rochoa
Copy link
Contributor

rochoa commented Jun 19, 2015

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants