Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixer perspective on routed layer #1307

Open
RuneFog opened this issue May 31, 2020 · 14 comments
Open

Mixer perspective on routed layer #1307

RuneFog opened this issue May 31, 2020 · 14 comments

Comments

@RuneFog
Copy link

RuneFog commented May 31, 2020

Expected behaviour

mixer perspective on a routed layer should be treated as one source

Current behaviour

mixer perspective on a routed layer is applied on each individual layer in the origin channel


Steps to reproduce

  1. PLAY 2-10 "2017_GR01_CHAMPIONSHIP" CUT 1 Linear RIGHT LOOP
  2. PLAY 2-20 "2017_GR01_CHAMPIONSHIP" CUT 1 Linear RIGHT LOOP
  3. MIXER 2-10 FILL 0.116667 0.516667 0.333333 0.333333 1 Linear
  4. MIXER 2-20 FILL 0.533333 0.516667 0.333333 0.333333 1 Linear
  5. PLAY 1-10 route://2
  6. MIXER 1-10 PERSPECTIVE 0 0.733333 0.733333 0.166667 0.8 1.06667 -0.0666667 1.03333 14 Linear
[2020-05-31 09:51:09.964] [info]    ############################################################################
[2020-05-31 09:51:09.965] [info]    CasparCG Server is distributed by the Swedish Broadcasting Corporation (SVT)
[2020-05-31 09:51:09.965] [info]    under the GNU General Public License GPLv3 or higher.
[2020-05-31 09:51:09.965] [info]    Please see LICENSE.TXT for details.
[2020-05-31 09:51:09.965] [info]    http://www.casparcg.com/
[2020-05-31 09:51:09.965] [info]    ############################################################################
[2020-05-31 09:51:09.965] [info]    Starting CasparCG Video and Graphics Playout Server 2.3.0 14f52882 Dev
[2020-05-31 09:51:11.138] [info]    Initializing OpenGL Device.
[2020-05-31 09:51:11.140] [info]    Initialized OpenGL 4.5.0 NVIDIA 376.84 NVIDIA Corporation
[2020-05-31 09:51:11.142] [info]    Initialized ffmpeg module.
[2020-05-31 09:51:11.142] [info]    Initialized oal module.
[2020-05-31 09:51:11.142] [info]    Initialized decklink module.
[2020-05-31 09:51:11.143] [info]    Initialized screen module.
[2020-05-31 09:51:11.143] [info]    Initialized newtek module.
[2020-05-31 09:51:11.216] [info]    Initialized html module.
[2020-05-31 09:51:11.353] [info]    Initialized flash module.
[2020-05-31 09:51:11.354] [info]    Initialized bluefish module.
[2020-05-31 09:51:11.354] [info]    Initialized image module.
[2020-05-31 09:51:11.354] [info]    "C:/Users\runef\Tools\Casparcg\2.2.x\casparcg.config":
[2020-05-31 09:51:11.354] [info]    -----------------------------------------
[2020-05-31 09:51:11.354] [info]    <?xml version="1.0" encoding="utf-8"?>
[2020-05-31 09:51:11.354] [info]    <configuration>
[2020-05-31 09:51:11.354] [info]       <paths>
[2020-05-31 09:51:11.354] [info]          <media-path>../media/</media-path>
[2020-05-31 09:51:11.354] [info]          <log-path>log/</log-path>
[2020-05-31 09:51:11.354] [info]          <data-path>data/</data-path>
[2020-05-31 09:51:11.354] [info]          <template-path>template/</template-path>
[2020-05-31 09:51:11.354] [info]          <font-path>font/</font-path>
[2020-05-31 09:51:11.354] [info]       </paths>
[2020-05-31 09:51:11.354] [info]       <lock-clear-phrase>secret</lock-clear-phrase>
[2020-05-31 09:51:11.354] [info]       <channels>
[2020-05-31 09:51:11.354] [info]          <channel>
[2020-05-31 09:51:11.354] [info]             <video-mode>1080i5000</video-mode>
[2020-05-31 09:51:11.354] [info]             <consumers>
[2020-05-31 09:51:11.354] [info]                <decklink>
[2020-05-31 09:51:11.354] [info]                   <device>5</device>
[2020-05-31 09:51:11.354] [info]                   <embedded-audio>true</embedded-audio>
[2020-05-31 09:51:11.354] [info]                   <latency>normal</latency>
[2020-05-31 09:51:11.354] [info]                   <keyer>external</keyer>
[2020-05-31 09:51:11.354] [info]                   <key-only>false</key-only>
[2020-05-31 09:51:11.354] [info]                   <buffer-depth>3</buffer-depth>
[2020-05-31 09:51:11.354] [info]                </decklink>
[2020-05-31 09:51:11.354] [info]             </consumers>
[2020-05-31 09:51:11.354] [info]          </channel>
[2020-05-31 09:51:11.354] [info]          <channel>
[2020-05-31 09:51:11.354] [info]             <video-mode>1080i5000</video-mode>
[2020-05-31 09:51:11.354] [info]             <consumers>
[2020-05-31 09:51:11.354] [info]                <screen/>
[2020-05-31 09:51:11.354] [info]             </consumers>
[2020-05-31 09:51:11.354] [info]          </channel>
[2020-05-31 09:51:11.354] [info]       </channels>
[2020-05-31 09:51:11.354] [info]       <controllers>
[2020-05-31 09:51:11.354] [info]          <tcp>
[2020-05-31 09:51:11.354] [info]             <port>5250</port>
[2020-05-31 09:51:11.354] [info]             <protocol>AMCP</protocol>
[2020-05-31 09:51:11.354] [info]          </tcp>
[2020-05-31 09:51:11.354] [info]       </controllers>
[2020-05-31 09:51:11.354] [info]       <amcp>
[2020-05-31 09:51:11.354] [info]          <media-server>
[2020-05-31 09:51:11.354] [info]             <host>localhost</host>
[2020-05-31 09:51:11.354] [info]             <port>8000</port>
[2020-05-31 09:51:11.354] [info]          </media-server>
[2020-05-31 09:51:11.354] [info]       </amcp>
[2020-05-31 09:51:11.354] [info]    </configuration>
[2020-05-31 09:51:11.354] [info]    -----------------------------------------
[2020-05-31 09:51:11.368] [info]    Initialized OpenGL Accelerated GPU Image Mixer for channel 1
[2020-05-31 09:51:11.371] [info]    video_channel[1|1080i5000] Successfully Initialized.
[2020-05-31 09:51:11.371] [info]    Initialized OpenGL Accelerated GPU Image Mixer for channel 2
[2020-05-31 09:51:11.371] [info]    video_channel[2|1080i5000] Successfully Initialized.
[2020-05-31 09:51:11.687] [info]    DeckLink HD Extreme 3D+ [1-5|1080i5000] Enabled embedded-audio.
[2020-05-31 09:51:11.687] [info]    DeckLink HD Extreme 3D+ [1-5|1080i5000] Disabled low-latency mode.
[2020-05-31 09:51:11.687] [info]    DeckLink HD Extreme 3D+ [1-5|1080i5000] Enabled external keyer.
[2020-05-31 09:51:11.691] [info]    DeckLink HD Extreme 3D+ [1-5|1080i5000] Initialized.
[2020-05-31 09:51:11.693] [info]    Screen consumer [2|1080i5000] Initialized.
[2020-05-31 09:51:11.693] [info]    Initialized channels.
[2020-05-31 09:51:11.699] [info]    Initialized controllers.
[2020-05-31 09:51:11.699] [info]    Initialized osc.
[2020-05-31 09:51:11.844] [info]    DeckLink HD Extreme 3D+ [1-5|1080i5000] Reference signal: not detected.
[2020-05-31 09:51:12.713] [info]    async_event_server[:5250] Accepted connection from 192.168.0.47 (1 connections).
[2020-05-31 09:51:12.713] [info]    Received message from 192.168.0.47: VERSION SERVER\r\n
[2020-05-31 09:51:12.714] [info]    Sent message to 192.168.0.47:201 VERSION OK\r\n2.3.0 14f52882 Dev\r\n
[2020-05-31 09:51:12.714] [info]    Received message from 192.168.0.47: INFO\r\n
[2020-05-31 09:51:12.715] [info]    Sent message to 192.168.0.47:200 INFO OK\r\n1 1080i5000 PLAYING\r\n2 1080i5000 PLAYING\r\n\r\n
[2020-05-31 09:51:12.715] [info]    Received message from 192.168.0.47: CLS\r\n
[2020-05-31 09:51:12.717] [info]    Received message from 192.168.0.47: TLS\r\n
[2020-05-31 09:51:12.718] [info]    Received message from 192.168.0.47: DATA LIST\r\n
[2020-05-31 09:51:12.720] [info]    Received message from 192.168.0.47: THUMBNAIL LIST\r\n
[2020-05-31 09:51:12.747] [info]    Sent message to 192.168.0.47:200 CLS OK\r\n"2017_GR01_CHAMPIONSHIP"  MOVIE  116134450 20200529164746 2213 1/25\r\n\r\n
[2020-05-31 09:51:12.754] [info]    Sent message to 192.168.0.47:200 TLS OK\r\n\r\n
[2020-05-31 09:51:12.755] [info]    Sent message to 192.168.0.47:200 DATA LIST OK\r\n\r\n
[2020-05-31 09:51:12.766] [info]    Sent message to 192.168.0.47:200 THUMBNAIL LIST OK\r\n"2017_GR01_CHAMPIONSHIP" 20200529T164746 304\r\n\r\n
[2020-05-31 09:51:26.516] [info]    Received message from 192.168.0.47: PLAY 2-10 "2017_GR01_CHAMPIONSHIP" CUT 1 Linear RIGHT   LOOP\r\n
[2020-05-31 09:51:26.521] [info]    Sent message to 192.168.0.47:202 PLAY OK\r\n
[2020-05-31 09:51:34.065] [info]    Received message from 192.168.0.47: PLAY 2-20 "2017_GR01_CHAMPIONSHIP" CUT 1 Linear RIGHT   LOOP\r\n
[2020-05-31 09:51:34.069] [info]    Sent message to 192.168.0.47:202 PLAY OK\r\n
[2020-05-31 09:51:39.070] [info]    Received message from 192.168.0.47: MIXER 2-10 MIPMAP 0\r\n
[2020-05-31 09:51:39.070] [info]    Sent message to 192.168.0.47:400 ERROR\r\nMIXER 2-10 MIPMAP 0\r\n
[2020-05-31 09:51:39.073] [info]    Received message from 192.168.0.47: MIXER 2-10 FILL 0.116667 0.516667 0.333333 0.333333 1 Linear\r\n
[2020-05-31 09:51:39.073] [info]    Sent message to 192.168.0.47:202 MIXER OK\r\n
[2020-05-31 09:51:44.881] [info]    Received message from 192.168.0.47: MIXER 2-20 MIPMAP 0\r\n
[2020-05-31 09:51:44.882] [info]    Sent message to 192.168.0.47:400 ERROR\r\nMIXER 2-20 MIPMAP 0\r\n
[2020-05-31 09:51:44.883] [info]    Received message from 192.168.0.47: MIXER 2-20 FILL 0.533333 0.516667 0.333333 0.333333 1 Linear\r\n
[2020-05-31 09:51:44.883] [info]    Sent message to 192.168.0.47:202 MIXER OK\r\n
[2020-05-31 09:51:54.573] [info]    Received message from 192.168.0.47: PLAY 1-10 route://2\r\n
[2020-05-31 09:51:54.574] [info]    Sent message to 192.168.0.47:202 PLAY OK\r\n
[2020-05-31 09:51:57.303] [info]    Received message from 192.168.0.47: MIXER 1 MASTERVOLUME 1\r\n
[2020-05-31 09:51:57.304] [info]    Sent message to 192.168.0.47:202 MIXER OK\r\n
[2020-05-31 09:51:57.814] [info]    Received message from 192.168.0.47: MIXER 1 MASTERVOLUME 0\r\n
[2020-05-31 09:51:57.814] [info]    Sent message to 192.168.0.47:202 MIXER OK\r\n
[2020-05-31 09:52:10.047] [info]    Received message from 192.168.0.47: MIXER 1-10 MIPMAP 0\r\n
[2020-05-31 09:52:10.047] [info]    Sent message to 192.168.0.47:400 ERROR\r\nMIXER 1-10 MIPMAP 0\r\n
[2020-05-31 09:52:10.049] [info]    Received message from 192.168.0.47: MIXER 1-10 PERSPECTIVE 0 0.733333 0.733333 0.166667 0.8 1.06667 -0.0666667 1.03333 14 Linear\r\n
[2020-05-31 09:52:10.049] [info]    Sent message to 192.168.0.47:202 MIXER OK\r\n1.
  1. ...

Environment


Screenshots

Screenshot and intial comments at https://casparcgforum.org/t/distort-perspective-weird-behaviour/3175

@5opr4ni
Copy link
Contributor

5opr4ni commented May 31, 2020

Hi

Tried this and can confirm that it behaves the same in 2.3
Have you tried if it behaves the same in 2.1?

/olle

@mint-dewit
Copy link
Member

I'm not sure how that build ended up in that folder on the build server, but your logs seems to imply you're actually running server 2.3 beta 1 and not server 2.2

This sounds a lot like a regression caused by zero delay channel routes (cc @scriptorian)

@ronag
Copy link
Member

ronag commented May 31, 2020

I'm not sure how that build ended up in that folder on the build serve_

@dotarmin

@RuneFog
Copy link
Author

RuneFog commented May 31, 2020

I'm not sure how that build ended up in that folder on the build server, but your logs seems to imply you're actually running server 2.3 beta 1 and not server 2.2

This sounds a lot like a regression caused by zero delay channel routes (cc @scriptorian)

My bad, that was actually 2.3 beta1
But I get the same result in 2.2.
(Must have mixed up the .zips)

The issue is not present in 2.1.x latest build

@jesperstarkar
Copy link
Contributor

@5opr4ni could this be the new bug you mentioned during the TSC meeting?

@ronag
Copy link
Member

ronag commented Jun 1, 2020

At this point I think we should just revert the zero delay commit...

@jesperstarkar
Copy link
Contributor

@ronag this bug seems to track back as a 2.2 regression and does not look to be related to the new routing.

@jesperstarkar
Copy link
Contributor

image
Tested and confirmed to be the same bug in 2.2 #f0d65d66

@Julusian
Copy link
Member

Julusian commented Jun 1, 2020

I suspect this will be some incorrect maths when combining the transforms in which case it could also be an issue in 2.1 with the scene producer but when nesting a scene inside another scene.

Is this a blocker for 2.3.0? I dont think I will have time to look at it for then

@dotarmin
Copy link
Contributor

dotarmin commented Jun 1, 2020

@ronag I'm not sure how that build ended up in that folder on the build serve_

A provisioning didn't go as expected. Fixed now and a new build is available for v2.2.x branch and same for v2.3.x-lts branch.

@5opr4ni
Copy link
Contributor

5opr4ni commented Jun 1, 2020

@5opr4ni could this be the new bug you mentioned during the TSC meeting?

Nope! My issue has to do with this command MIXER 1-8 KEYER 1. I will come back with an issue when I have made a proper description.

@5opr4ni
Copy link
Contributor

5opr4ni commented Jun 1, 2020

I suspect this will be some incorrect maths when combining the transforms in which case it could also be an issue in 2.1 with the scene producer but when nesting a scene inside another scene.

Is this a blocker for 2.3.0? I dont think I will have time to look at it for then

No!

@dotarmin
Copy link
Contributor

dotarmin commented Jun 1, 2020

I agree with @5opr4ni, it's not a blocker because the same behaviour exists in v2.2. However i would like to see it fixed in v2.3.1 LTS and have it as a part of the LTS version.

@Julusian
Copy link
Member

Julusian commented Jan 5, 2024

I believe this was caused by the changes to how routing works, so that it forwards frames before they are composited rather than after. This is causing the way transforms are combined to not work correctly.
Fixing this combining looks to be complex, and is probably best done by resurrecting and finishing 777b7f2

@Julusian Julusian removed this from the v2.3.1 LTS milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants