Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show type material on taxon & names page #466

Closed
mdoering opened this issue Dec 20, 2019 · 9 comments
Closed

Show type material on taxon & names page #466

mdoering opened this issue Dec 20, 2019 · 9 comments
Assignees

Comments

@mdoering
Copy link
Member

Type Material now exists as an entity on its own. Please show it on the taxon and name details pages:

Taxon
The TaxonInfo object now has a map typeMaterial of type nameID --> List<TypeMaterial>. It is keyed on the nameID so the UI can quickly lookup the types for a given name (taxon.name or any of the synonyms).

Show a types material icon next to each name if any data exists, similar to references.

Discuss how to best present the types. As homotypic names are based on the same types and we recommend only to link types to original names, types should ideally only be shown for original names.

Name
The API has a new method /name/{KEY}/types to list all types for a given name.

The ColDP examples dataset contains 3 types to test with.

@mdoering
Copy link
Member Author

Not all type information seems to be shown. This IPNI type
https://api.dev.checklistbank.org/dataset/144889/name/77126065-1/types

Only shows as Holotype but lacks information on date, collector, locality & remarks

@mdoering mdoering reopened this May 12, 2022
@mdoering
Copy link
Member Author

It would be nice to follow the EJT material_citations_formatting_guide recommendation on how to present material citations.

The preferred order of data fields is as follows:
COUNTRY • specimen(s) [e.g. “1 ♂”]; geographic/locality data [from largest to smallest]; geographic coordinates; altitude/elevation/depth [using alt. / elev. / m a.s.l. etc.]; date [format: 16 Jan. 1998]; collector [followed by “leg.”]; other collecting data [e.g. micro habitat / host / method of collecting / “DNA voucher specimen”/ “vial with detached elements”, etc.]; barcodes/identifiers [e.g. “GenBank: MG779236”]; institution code and specimen code [e.g. “CBF 06023”].

Example:
image

We don't have all fields yet in our model, but we will extend it in the near future:
CatalogueOfLife/coldp#64

@thomasstjerne
Copy link
Contributor

thomasstjerne commented May 16, 2022

The UI shows only the type and the citation string - I kind of assumed that it would be generated by the backend. Like for references

@mdoering
Copy link
Member Author

I guess I could built it - preferrably not with any html. Makes sense, it's similar to references and taxon labels I suppose.

@mdoering
Copy link
Member Author

I will produce it on the fly when missing

@thomasstjerne
Copy link
Contributor

Also, for e.g. the Index Fungorum data I found that it was quite difficult to structure the data, so it ends up in just the status and citation. This way, it could be given either structured and the citation generated or as a single string

@mdoering
Copy link
Member Author

I have tried to parse the coordinates into decimal values - would it make sense to render to tiny map thumbnail or the globe like we do on gbif events?

@thomasstjerne
Copy link
Contributor

That would be great

@mdoering
Copy link
Member Author

deployed to prod, seems to work fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants