Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export is aborted when the phone is rotated #1715

Closed
guy-teube opened this issue Jan 30, 2024 · 2 comments
Closed

Export is aborted when the phone is rotated #1715

guy-teube opened this issue Jan 30, 2024 · 2 comments
Labels
common: occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers severity: critical Prevents work, causes data loss and/or has no workaround type: bug Something isn't working

Comments

@guy-teube
Copy link

Steps to reproduce:

  1. Run an export from the parameters of the app, choose a password and a directory
  2. During the export, rotate the phone (it has to be allowed in the parameters of the phone)
  3. Catima closes the export loading spinner, and displays the Import/export screen. No file is generated.

Expected result:
The export file should be run until the end regardless of orientation of the phone, and the export file should be generated

Reproduced with 2.26.0 version, on Android 13

@TheLastProject
Copy link
Member

This is kind of a duplicate of #513 (it's the same issue), but I guess this specific case could be worked around by force-disabling rotation in the import/export activity to reduce the risk of accidental cancellations.

Of course #513 does still need to be fixed too.

@TheLastProject TheLastProject added type: bug Something isn't working good first issue Good for newcomers severity: critical Prevents work, causes data loss and/or has no workaround common: occasional Affects or can be seen by some users regularly or most users rarely labels Jan 30, 2024
@TheLastProject
Copy link
Member

I implemented a workaround in d24366a by locking the orientation in the ImportExportActivity. It's hacky, but not being able to rotate the screen is less bad than the import/export failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common: occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers severity: critical Prevents work, causes data loss and/or has no workaround type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants