Implement Better, Faster, Non-Broken Caching #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der, this is everything that is changed by that
… a 2-way dependency tree after parse, and update the shuffler to work with this parse. Spoilers currently broken
…oss seeds even if the setting is changed so long as the randomizer isn't restarted.
…en-caching # Conflicts: # MinishCapRandomizerCLI/Program.cs # RandomizerCore/Randomizer/Shuffler.cs
…ut and removed old testing breakpoint statement from shuffler
|
This can now be merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Myth's most recent change to the logic dependencies we now have a 0% failure rate over 200 generated seeds, one with max random and one with default. As such, I am deeming this ready for merge and ready for release.
Timing statistics and graphs to compare caching seed generation times to non-caching generation times: https://docs.google.com/spreadsheets/d/e/2PACX-1vSB_SEeE4E-EuLKdTtmWwHusvP5526LNViuxj8_89M3X6AtNh2kNzSnwKzS0PJbAxRR0rsEmfLS_plZ/pubhtml
Overall average performance improvement for max random settings - 90%
Overall average performance improvement for default settings - 97.5%
Hendrus shuffler speedup - 50k permutations down from 12 minutes to 6 seconds, total improvement of 99.2% or a 120x speedup!
Additionally, this patch added CLI support for command files. Before this gets merged I want to update the readme with the commands for this file for people to use. There are a few settings that are currently only available with the command files that need to be documented.