Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create function to easily modify the fontSize, fontWeight and lineHeight properties of the text #2

Open
Cedar-81 opened this issue Oct 19, 2023 · 4 comments
Open

Create function to easily modify the fontSize, fontWeight and lineHeight properties of the text #2

Cedar-81 opened this issue Oct 19, 2023 · 4 comments
Assignees
@sushma1031
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest For Hacktober contributors

Comments

@Cedar-81
Copy link
Owner

Cedar-81 commented Oct 19, 2023 •
edited
Loading

In the typescript file(Paginate.ts), there are variables to specify the line height, font weight, and font size. It would be nice if a function is created to update these values.

This function should serve as an api to modify these values apart from the the assignment that happens on initialization.

Also, inputs can be added to the current html to utilize this api.

Goodluck 👍💪
@Cedar-81 Cedar-81 added enhancement New feature or request hacktoberfest For Hacktober contributors good first issue Good for newcomers labels Oct 19, 2023
@sushma1031
Copy link

Hello, I'd like to work on this, could you please assign it to me?

@Cedar-81
Copy link
Owner Author

Cedar-81 commented Oct 19, 2023 •
edited
Loading

Sure, let me do just that.

Feel free to leave any questions here if you encounter any issues

@sushma1031
Copy link

Hey, there's no variable for font weight in Paginate.ts. So shall I just create functions for font size and line height?

@Cedar-81
Copy link
Owner Author

Okay cool, ignore it, it was an error on my end

@sushma1031 sushma1031 mentioned this issue Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sushma1031 sushma1031

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest For Hacktober contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add functions to modify text properties
2 participants
@Cedar-81 @sushma1031