Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ClearBorders and RemoveObjectsBySize modules #3218

Closed
AnneCarpenter opened this issue Sep 18, 2017 · 4 comments
Closed

Remove ClearBorders and RemoveObjectsBySize modules #3218

AnneCarpenter opened this issue Sep 18, 2017 · 4 comments
Assignees

Comments

@AnneCarpenter
Copy link
Member

The help for FilterObjects indicates that it works in 3D to remove objects touching the border of the image, making ClearBorders redundant.

@mcquin says "FilterObjects will clear the image border or mask border (if not objects touch the image edge). ClearBorder just clears the image border, so it's redundant. I am in favor of removing it. There is a setting in ClearBorder for removing objects N pixels from the edge, which is interesting, but it's not hooked up to anything."

Regarding that ^^^, a workaround might be to crop the image then filter objects touching edges. So I think we are clear.

Any other comments? I think @0x00b1 wrote this module so tagging him to see if there is a use case we are not thinking of.

@AnneCarpenter
Copy link
Member Author

Confirmation that FilterObjects actually does work in 3D would be reassuring before we do this!

@mcquin
Copy link
Contributor

mcquin commented Sep 18, 2017

FilterObjects got 3D support in #2694

@AnneCarpenter
Copy link
Member Author

Consensus is that this module can indeed be deleted.

@AnneCarpenter AnneCarpenter changed the title Remove ClearBorders module Remove ClearBorders and RemoveObjectsBySize modules Sep 19, 2017
@AnneCarpenter
Copy link
Member Author

Also, we can delete RemoveObjectsBySize. Per @mcquin , "RemoveObjectsBySize was added Nov '16, before FilterObjects. It is redundant now that FilterObjects supports 3D. We can remove it."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants