New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility fixes for stable branch #3455
Conversation
Backport of 75e7b2c which was merged as part of 1ee421f in CellProfiler#2891. During development of CellProfiler/centrosome#74 and CellProfiler/centrosome#75, an API incompatibility was introduced where `centrosome.zernike.zernike()` and by extension `centrosome.zernike.construct_zernike_lookuptable()` no longer accept an empty list as input for `zernike_indexes`. This makes `centrosome>=1.0.8` incompatible with `CellProfiler<=3.0.0` and source installs of such versions not work with pipelines where Zernike calculation is turned off.
6f92465
to
5b792f4
Compare
59e134e
to
7b567f7
Compare
76e620d
to
90a0578
Compare
Now that Travis is passing some notes follow related to the above commits for anyone who wants to understand rationale or comes across any of these problems during deployment:
Instances of [3] related to javabridge will manifest themselves as::
and:
Instances of [7] will manifest themselves as:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @chris-allan! Thanks for providing context along with your changes.
A couple of compatibility fixes targeting the stable branch which backport changes from
master
for those of us who are either still using 2.2.x or need to compare 2.2.x outputs with 3.x.Without 65aa2e0, which is a backport of changes from #2891, an installation from source today when using pipelines which contain the
MeasureObjectSizeShape
module and have Zernike calculation turned off will throw the following exception:Example pipeline used:
An alternative is to pin centrosome to
1.0.5
. This was the version that 2.2.0 was released with.CellProfiler 2.2.x is also incompatible with numpy >= 1.12.0 so pinning this version makes sense to avoid users shooting themselves in the foot. This was reflected in #2588 and relaxed in #2596 with the addition of support for 1.12.0+. An alternative would be to backport the changes from #2596 while being quite careful about the corresponding centrosome dependency.
/cc @emilroz, @stick