Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/4373 #4397

Merged
merged 17 commits into from Jun 14, 2021
Merged

Issues/4373 #4397

merged 17 commits into from Jun 14, 2021

Conversation

pearlryder
Copy link
Collaborator

This PR closes issue #4373 - it incorporates optional advanced settings for the Watershed module to allow declumping using either a shape-based or an intensity-based method. Tests are included.

@@ -83,6 +85,25 @@
Higher values result in more regularly-shaped watershed basins.

.. _compact watershed: http://scikit-image.org/docs/0.13.x/api/skimage.morphology.html#r395

Selecting *Advanced Settings* will split the detected objects into smaller objects based on a seeded watershed method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a line at the end here acknowledging that this code comes from the DeclumpObjects plugin by Madison Bowden?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, of course! I've since added attribution to Madison w/ my most recent commit.

@bethac07 bethac07 merged commit b6aac73 into master Jun 14, 2021
@bethac07 bethac07 deleted the issues/4373 branch June 14, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate the declump objects plugin into the CellProfiler Watershed module
2 participants