Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Fix issue with deleting firefox atmention #3

Merged
merged 2 commits into from Jun 23, 2017
Merged

[Feature] Fix issue with deleting firefox atmention #3

merged 2 commits into from Jun 23, 2017

Conversation

fabmiz
Copy link
Member

@fabmiz fabmiz commented Jun 22, 2017

Purpose

Allow deleting atmention with backspace in Firefox

Changes

Revert ichord#423 to allow deleting atmention in Firefox:

  • Sets atmention contenteditable attr to default, true.
  • Add back zero width joiner

@sloria
Copy link

sloria commented Jun 22, 2017

The change should be made in the source file: src/editableController.coffee then built. See https://github.com/ichord/At.js/pull/423/files#diff-aaed6e81e22e8af2e46cfd2b6585d21eL162

sloria
sloria suggested changes Jun 22, 2017
View reviewed changes
Copy link

@sloria sloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass finished.

@sloria sloria merged commit 36a84fb into CenterForOpenScience:cos Jun 23, 2017
@laurenbarker laurenbarker mentioned this pull request Sep 7, 2017
Open
@cubeguerrero cubeguerrero mentioned this pull request Jul 20, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloria sloria sloria requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fabmiz @sloria