[ZD-2703623] deleting space after @mention cursor jump #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zendesk/orchid |
gregziegan
approved these changes
Jul 23, 2018
cubeguerrero
deleted the
cubeguerero/ZD2703623-deleting_space_after_@mention_cursor_jump
branch
albertldlan
added a commit
that referenced
this pull request
Nov 28, 2018
In `at.js` the zero width joiner unicode character (\u200D) is inserted after an at-mention is inserted into the rich text editor (for our use case, the at-mention is a condition placeholder). This zwj character causes problems with the cursor - additionally, the use case for the zwj character is very specific and in its current form does not do anything. By switching to a zero width space character we can preserve the spirit of the original implementation and fix the cursor issue. This was tested on Google Chrome, Firefox, and Safari. The zwj character was added to `at.js` in this PR: #7 - it's important to make sure we are not introducing any regressions with this change.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pull request fixes the cursor jumping problem when using
@mentioninside the content editor inzendesk_console. Whenever we use emoji and the mention functionality, theAt.jlibrary inserts aspanwith the attributecontenteditable=falsewhile our content editor (see.zendesk-editor--rich-text-comment) has the attributecontenteditable=true. Right now, this kind of nesting is buggy and will cause weird behavior.cc @zendesk/sustaining @zendesk/harrier
Please see these PR's for reference:
Pull request that introduced the bug:
ichord#423
Pull requests looking to reverse or have already been reversed:
ichord#463
CenterForOpenScience#3
Description
Zendesk Support Ticket 2703623
Steps to reproduce:
/agent/tickets/<ticket-number>Before
Google Chrome
Safari
After
Google Chrome
Safari
Todo
zendesk_consoleto update thepackage.jsonRisks
Low: the change just removes an attribute in html which the library doesn't use and adds \u200D as hack for the cursor positioning.