Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication-based routing #68

Closed
XanderVertegaal opened this issue May 15, 2024 · 1 comment · Fixed by #90
Closed

Authentication-based routing #68

XanderVertegaal opened this issue May 15, 2024 · 1 comment · Fixed by #90
Assignees
@XanderVertegaal

Comments

@XanderVertegaal
Copy link
Contributor

This becomes relevant once we have more non-authentication routes.

  • The user should be brought back to the page they were on when going through the logging flow.
  • Route guards provide better UX.
@XanderVertegaal XanderVertegaal mentioned this issue May 15, 2024
Merged
@lukavdplas
Copy link
Contributor

I-analyzer has a LoggedOnGuard which I forgot to transfer; that should be a good basis.

@XanderVertegaal XanderVertegaal mentioned this issue Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XanderVertegaal XanderVertegaal

Labels
None yet
Projects
Lettercraft
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/authentication based routing CentreForDigitalHumanities/lettercraft
2 participants
@lukavdplas @XanderVertegaal