Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support URIs to GLB in Instanced 3D Models #45

Closed
javagl opened this issue Jun 11, 2023 · 1 comment
Closed

Properly support URIs to GLB in Instanced 3D Models #45

javagl opened this issue Jun 11, 2023 · 1 comment

Comments

@javagl
Copy link
Contributor

javagl commented Jun 11, 2023

The TileData payload field carries a note that it can either contain the GLB data or an URI.

Functions like glbToI3dm or the (internal) extractGlbBuffers always assume that the payload is an embedded GLB. But this should be generalized. This will include some minor implementations for on-the-fly resolving of the GLB data from the URI and the corresponding error handling. It may also involve extending the CLI. For example, one could consider to offer an option like

... glbToI3dm -i input.glb -o output.i3dm -useUriForGlb
                                           ^--- this

at the command line.

@javagl
Copy link
Contributor Author

javagl commented Nov 9, 2023

The PR #83 covers most of this: The functions that deal with I3DMs now usually receive an externalGlbResolver, which is a function that takes a URI and returns the Buffer with the data. (There are some degrees of freedom for things like error handling, but the main point is that external GLBs should now be supported more consistently).

The idea of generalizing the glbToI3dm command is now tracked in #84

@javagl javagl closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant