Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator bounding volume and transform #173

Closed
phanemy opened this issue Mar 20, 2019 · 2 comments
Closed

Validator bounding volume and transform #173

phanemy opened this issue Mar 20, 2019 · 2 comments

Comments

@phanemy
Copy link

phanemy commented Mar 20, 2019

Hello, i'm writing a 3Dtile generator from 3d mesh and I use the validator to check if my tiles are good.

My first issue was to find the working validator, in master branch validator don't work, in validator-master branch same, the good one was in validator branch, maybe merge it into the master branch to make is utilisation more simple.

My second issue was related to the boundingBox, i don't know if it's coming from my compréhension of the 3d tile spécification, but for me the bounding volume(box one) is in the same space as the tile and is affected by parents tiles transform and local, but with this idea the validator says my bounding box wasn't in parent box. After searching in utility.js file I find that boundingBox only use the local transform of is tile without parents transform. Is that normal or not? which philosophy is the good one.

Thanks for your answer.

@javagl
Copy link
Contributor

javagl commented Oct 3, 2022

It could be helpful to have an example tileset file that shows the problem. But in general, the checkBoundingVolume that you referred to is only called for tile and the tile content. It does not check wheter a child bounding volume is contained in the parent bounding volume, because this is not required by the specification, and often not the case. See https://github.com/CesiumGS/3d-tiles/blob/main/specification/README.md#bounding-volume-spatial-coherence for examples.

@javagl
Copy link
Contributor

javagl commented Feb 27, 2024

I'll close this due to inactivity (and the request is not perfectly clear either - and it referred to the "old" state of the validator anyhow).

Some possible improvements for the bounding volume validation are tracked in #233 .

@javagl javagl closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants