Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Hyperlink to Bing Maps ToU instead of Bing Maps top page #11048

Closed
Lakshmi0710 opened this issue Jan 25, 2023 · 4 comments
Closed

Provide Hyperlink to Bing Maps ToU instead of Bing Maps top page #11048

Lakshmi0710 opened this issue Jan 25, 2023 · 4 comments

Comments

@Lakshmi0710
Copy link
Contributor

Lakshmi0710 commented Jan 25, 2023

Requested feature
Provide Hyperlink to Bing Maps ToU instead of Bing Maps top page.
Please replace the current link to the Bing Maps page with Bing Maps end user ToU.
Link: https://www.microsoft.com/en-us/maps/product/enduserterms

Steps
click the "Data attribution" link on the left bottom of the 3D view.
click the Bing Map link in the "Data Provided by " window.
image

@Lakshmi0710
Copy link
Contributor Author

Lakshmi0710 commented Jan 25, 2023

I think this url is hard coded in this line https://github.com/CesiumGS/cesium/blob/main/packages/engine/Source/Scene/BingMapsImageryProvider.js at #L180

@ggetz
Copy link
Contributor

ggetz commented Jan 25, 2023

Thanks @Lakshmi0710! We'd be happy to review a PR with this change.

@Lakshmi0710
Copy link
Contributor Author

Lakshmi0710 commented Jan 25, 2023

@ggetz Raised PR #11049, Please review it and let me know if you require any additional information. Thanks

@ggetz
Copy link
Contributor

ggetz commented Jan 31, 2023

Addressed in #11049.

@ggetz ggetz closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants