Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Tiles Sandcastle example has mouse issues in IE 11 #3614

Closed
mramato opened this issue Feb 22, 2016 · 13 comments
Closed

3D Tiles Sandcastle example has mouse issues in IE 11 #3614

mramato opened this issue Feb 22, 2016 · 13 comments

Comments

@mramato
Copy link
Contributor

mramato commented Feb 22, 2016

Obviously not a big deal until we are ready to bring 3d-tiles into master, but I wanted to submit this before I forget.

The mouse doesn't behave as expected when running the 3D Tiles Sandcastle example in IE11. Panning and rotation are wildly inaccurate. Running the demo in Chrome works fine. It looks like other examples work fine in the 3d-tiles branch, so maybe it's something specific to the new example.

@bicealyh
Copy link

The master branch also has the same problem. The mouse wheel does not respond In IE11.

@mramato
Copy link
Contributor Author

mramato commented Feb 28, 2016

@bicealyh you are correct, but the two are unrelated. This mouse wheel is actually a much bigger issue since it's broken in master. I submitted #3643 for us to fix this before the next release. Thanks for the heads up.

@pjcozzi
Copy link
Contributor

pjcozzi commented May 19, 2016

@TomPed would you like to try this one when you are available?

@TomPed
Copy link
Contributor

TomPed commented May 25, 2016

I'm trying to load the sandcastle example and I am getting an error:

An error occurred while rendering.  Rendering has stopped.
undefined
TypeError: Object doesn't support property or method 'fill'
TypeError: Object doesn't support property or method 'fill'
``'

@TomPed
Copy link
Contributor

TomPed commented May 26, 2016

This is the support for the fill method for Internet Explorer.

ieisbad

TypedArray.prototype.fill()

@mramato
Copy link
Contributor Author

mramato commented May 26, 2016

Up to @lilleyse and @pjcozzi, but if we think this will affect performance, we can write a helper function that calls fill if it's defined and falls back to iteration if it's not.

@pjcozzi
Copy link
Contributor

pjcozzi commented May 26, 2016

@mramato's approach is fine. Look in the file history; we just added fill so we were basically using the fallback beforehand.

@TomPed
Copy link
Contributor

TomPed commented Jun 6, 2016

Panning and rotation are wildly inaccurate.

@mramato when you say this, are you referring to the granularity of the panning and rotation, or when you go to pan and rotate, sometimes, no movement occurs. The latter is what I see.

@mramato mramato mentioned this issue Jul 6, 2016
@mramato
Copy link
Contributor Author

mramato commented Jul 26, 2016

@JoshuaStorm can you take a look at this? Create a new private function in Core called arrayFill, which uses the polyfill from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/fill, but instead of patching the prototype, have the function take the array as the first parameter. You'll also want to clean up the formatting and error checks to match our conventions as well as add specs.

In order to take advantage of fill on browsers that do support it, in arrayFill check if Array.prototype.fill exists first and if it does just us that instead. See getTimestamp for a simple example of setting this up.

Then you can update Cesium3DTileBatchTableResource.js and replace the calls to fill with the new function and verify it works in all browsers.

@JoshuaStorm
Copy link

@mramato I cannot seem to find Cesium3DTileBatchTableResources.js in this repo. Am I missing something?

@mramato
Copy link
Contributor Author

mramato commented Jul 26, 2016

This needs to be done in a branch off of 3d-tiles

@JoshuaStorm
Copy link

Makes sense, figured I was forgetting something like that.

@mramato
Copy link
Contributor Author

mramato commented Aug 2, 2016

There still seem to be several issues in the IE11 3D Tiles demo, but I'll try and write up more specific issues in place of this current one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants