Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

73 test failure in Firefox with WebGL Validation turned on. #3888

Open
mramato opened this issue May 1, 2016 · 16 comments
Open

73 test failure in Firefox with WebGL Validation turned on. #3888

mramato opened this issue May 1, 2016 · 16 comments

Comments

@mramato
Copy link
Contributor

mramato commented May 1, 2016

A half dozen Sun rendering tests fail and then ~50 or so ScreenSpaceEventHandler related tests.

I think it's okay to ship 1.21 with these validation-only failures, but I'd like to hear someone agree with that before tagging the 1.21 release.

@mramato
Copy link
Contributor Author

mramato commented May 1, 2016

I tested all of the Sandcastle examples in Firefox and everything works fine. Since everything is fine when running without webgl validation, I think we're good for 1.21, but we should definitely look at this for 1.22.

@pjcozzi
Copy link
Contributor

pjcozzi commented May 2, 2016

Agreed. OK for 1.21.

@bagnell
Copy link
Contributor

bagnell commented May 10, 2016

Do you still see 73? I see 9 and they are all Scene tests.

@mramato
Copy link
Contributor Author

mramato commented May 11, 2016

With the latest Firefox and master, I'm now seeing 10 failures. 9 in Scene and one in OrientedBoundingBox. I'm also getting AfterAll RuntimeError: WebGL Error: CONTEXT_LOST_WEBGL lost: deleteTexture([object WebGLTexture]) at the top of the test run.

@pjcozzi
Copy link
Contributor

pjcozzi commented May 31, 2016

Not required for 1.23 tomorrow. Could be worth a look at the code sprint.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 23, 2016

Not important enough for 1.23.

@hpinkos
Copy link
Contributor

hpinkos commented Aug 1, 2016

I only found one test failure left while doing the 1.24 release

@bagnell
Copy link
Contributor

bagnell commented Sep 30, 2016

For the 1.26 release I'm seeing 11 failures:

Scene/WebMapServiceImageryProvider pickFeatures works with GeoJSON responses
Scene/LabelCollection can render after adding a label
Scene/Scene debugShowGlobeDepth
Scene/Scene opaque/translucent render order (1)
Scene/Scene opaque/translucent render order (2)
Scene/Scene renders fast path with no translucent primitives
Scene/Scene renders with OIT and without FXAA
Scene/Scene renders map twice when in 2D
Scene/Scene pickPosition
Scene/Scene pickPosition returns undefined when useDepthPicking is false
Scene/Scene pickPosition throws without windowPosition

Majority of the errors are
WebGL Error: INVALID_OPERATION: drawElements or
WebGL Error: OUT_OF_MEMORY: drawElements

@mramato
Copy link
Contributor Author

mramato commented Nov 1, 2016

I'm still getting similar failures to @bagnell for 1.27

@hpinkos
Copy link
Contributor

hpinkos commented Feb 1, 2017

I can't run the WebGL validation tests without it crashing Firefox (51.0.1 64-bit)
The Scene specs seem to be causing the problem. Running the specs on the other folders works fine

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 1, 2017

I can't run the WebGL validation tests without it crashing Firefox (51.0.1 64-bit)
The Scene specs seem to be causing the problem. Running the specs on the other folders works fine

Covered in #4942

@shehzan10
Copy link
Member

Cross posting here. @hpinkos The culprit test/line is https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Specs/Scene/SceneSpec.js#L296.
If you exclude this test, you should be able to run the tests in firefox just fine.

@mramato
Copy link
Contributor Author

mramato commented Nov 1, 2017

This now crashes the Firefox tab completely.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 2, 2018

There's one failure in Chrome with WebGL validation:

Scene/Scene raises the preRender event prior to rendering
RuntimeError: WebGL Error: CONTEXT_LOST_WEBGL lost: undefined();

This passes when ran as an individual test, but fails when all the Scene tests are ran: http://localhost:8080/Specs/SpecRunner.html?webglValidation=&spec=Scene%2FScene

@hpinkos
Copy link
Contributor

hpinkos commented Mar 1, 2018

I got these 8 test failures when prepping the 1.43 release

  • Scene/Camera computeViewRectangle when zoomed in
  • Scene/Camera computeViewRectangle when zoomed in to IDL
  • DataSources/CzmlDataSource checks validation document
  • Scene/Expression evaluates exp function
  • Core/OrientedBoundingBox distanceSquaredTo
  • Scene/Vector3DTilePoints renders a point
  • Scene/Vector3DTilePoints renders a point with an image
  • Scene/PointCloud3DTileContent clipping planes union regions

Most of them looked like precision errors. Like Expected 16.000000000000014 to equal epsilon 16, 1e-14.

@lilleyse
Copy link
Contributor

lilleyse commented Apr 2, 2018

The errors I see (excluding #6408):

  • Scene/PointCloud3DTileContent clipping planes union regions (Float)
  • Scene/Scene always raises preUpdate event after updating (passes individually)
  • Scene/Vector3DTilePoints renders a point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants