-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
73 test failure in Firefox with WebGL Validation turned on. #3888
Comments
I tested all of the Sandcastle examples in Firefox and everything works fine. Since everything is fine when running without webgl validation, I think we're good for 1.21, but we should definitely look at this for 1.22. |
Agreed. OK for 1.21. |
Do you still see 73? I see 9 and they are all |
With the latest Firefox and master, I'm now seeing 10 failures. 9 in Scene and one in OrientedBoundingBox. I'm also getting |
Not required for 1.23 tomorrow. Could be worth a look at the code sprint. |
Not important enough for 1.23. |
I only found one test failure left while doing the 1.24 release |
For the 1.26 release I'm seeing 11 failures:
Majority of the errors are |
I'm still getting similar failures to @bagnell for 1.27 |
I can't run the WebGL validation tests without it crashing Firefox (51.0.1 64-bit) |
Covered in #4942 |
Cross posting here. @hpinkos The culprit test/line is https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Specs/Scene/SceneSpec.js#L296. |
This now crashes the Firefox tab completely. |
There's one failure in Chrome with WebGL validation:
This passes when ran as an individual test, but fails when all the |
I got these 8 test failures when prepping the 1.43 release
Most of them looked like precision errors. Like |
The errors I see (excluding #6408):
|
A half dozen Sun rendering tests fail and then ~50 or so
ScreenSpaceEventHandler
related tests.I think it's okay to ship 1.21 with these validation-only failures, but I'd like to hear someone agree with that before tagging the 1.21 release.
The text was updated successfully, but these errors were encountered: