Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into why CesiumJS release zip grew significantly larger in the 1.50 release #8284

Closed
hpinkos opened this issue Oct 14, 2019 · 4 comments · Fixed by #8294
Closed

Look into why CesiumJS release zip grew significantly larger in the 1.50 release #8284

hpinkos opened this issue Oct 14, 2019 · 4 comments · Fixed by #8294

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Oct 14, 2019

Screenshot_20191014-125239~2

I noticed this recently, and I couldn't find anything in CHANGES.md that explains why the packages suddenly grew by almost 30MB. It would be a good idea to make sure this is expected and not something we need to fix in our release.

@shunter
Copy link
Contributor

shunter commented Oct 14, 2019

#7006 added new test models with 30MB of PNG textures. Perhaps they can be reduced in size.

@OmarShehata
Copy link
Contributor

My bad, thanks for pointing that out Scott! We can definitely put a much smaller/less detailed model for the tests.

@hpinkos
Copy link
Contributor Author

hpinkos commented Oct 15, 2019

@OmarShehata is this something you can do before the next release?

@hpinkos
Copy link
Contributor Author

hpinkos commented Oct 15, 2019

nevermind @OmarShehata, i got it #8294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants