Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected output location #244

Closed
emackey opened this issue Feb 23, 2017 · 4 comments
Closed

Unexpected output location #244

emackey opened this issue Feb 23, 2017 · 4 comments

Comments

@emackey
Copy link

emackey commented Feb 23, 2017

When I run the pipeline with output like this:

node gltf-pipeline.js ... -o /d/my_folder/my_file.gltf

I get an unexpected result, a new output folder is created and the actual path written is:

/d/my_folder/output/my_file.gltf

This is mentioned in a comment buried in a large cleanup issue, but I feel this warrants its own dedicated issue. It seems quite unnatural for it to create a subfolder when I specifically targeted a folder and filename. It's bad for scripting too.

@shehzan10
Copy link
Member

Actually there are couple of different things happening based on the options which I will try to summarize here:

Input Options Output File
-i /path/to/input.gltf -o /path/to/result.gltf /path/to/output/ result.gltf
/path/to/input.gltf /path/to/result.gltf /path/to/output/ result.gltf
-i /path/to/input.gltf /path/to/output/input -optimized.gltf
/path/to/input.gltf /path/to/output/input -optimized.gltf

I think the best option would be to remove the directory creation (which seems to happen in all cases) and go with the suffixed -optimized if output is not specified.

@lilleyse thoughts?

@lilleyse
Copy link
Contributor

Yes definitely agree. Creating the output directory has gone back to the way beginnings of this project, but I would be fine with changing it.

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 23, 2017

@shehzan10 can you make this change?

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 23, 2017

Ah, I see #245, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants