Support for IE11, Edge and Firefox #11
Conversation
Support for IE11, Edge and Firefox of line clamping
|
@CezaryDanielNowak any update on this PR? |
|
@kkwiatkowski is this update containing some changes from Clamp.js forks? If so, please update comment at the top. |
| @@ -31,6 +36,9 @@ Dotdotdot.prototype.dotdotdot = function(container) { | |||
| }); | |||
| } | |||
| }; | |||
| Dotdotdot.prototype.update = function() { | |||
There was a problem hiding this comment.
Is this helper method needed? Maybe line 12 could be just this.update = this.forceUpdate.bind(this);
There was a problem hiding this comment.
It's not needed. It was added only for sake of clean code.
I'll update this in few secs.
There was a problem hiding this comment.
I've checked docs for forceUpdate and it is safer to leave it as it is.
Force update is expecting a callback as its first param, and doing it as you proposed will pass there an event. It might lead to unexpected behavior and should be avoided I guess.
|
@CezaryDanielNowak nop, this update doesn't contain any changes from Clamp.js forks. |
|
@CezaryDanielNowak Thanks for merge! I'm waiting for new release and npm update then :). |
This pull request introduce support for mentioned browsers.
It addresses issue #6 and probably #10 (this one should be checked).
If merged, please update on npm as well.