-
Notifications
You must be signed in to change notification settings - Fork 41
add regression testing and CI #132
Comments
@BeroBurny following our synch, PL would like ChainSafe to write down a proposal / plan to build those automated test for FilSnap. |
quick brain dump, hopefully some pointers will be useful / save time:
|
hey @lidel @autonome, sorry it took me a while to write a response here. We discussed this with Metamask already. We are maintaining https://github.com/chainsafe/dappeteer which uses puppeteer to install metamask into chrome/firefox and controls it. We could use it to write e2e tests for snaps right now, but we are delaying that as we are discussing integration directly into snaps cli, making it easier and faster to write those tests. Let us know if you would like us to wait a bit more to figure out if it's going to be integrated or to do it as is (in which case we should refactor if it gets integrated)? |
This is finally possible with dappeteer: https://github.com/ChainSafe/dappeteer#usage-with-snaps |
For production readiness for when Metamask flask architecture goes mainline, we want to ensure we are proactively notified when upstream MM changes to Flask architecture break the FIL snap.
Perhaps Glif and/or MetaMask folks already have testing frameworks to use and maybe even CI we can inject ourselves into (change the flow - their "build" breaks when FIL snap breaks).
cc @rekmarks @Schwartz10
The text was updated successfully, but these errors were encountered: