gs1.1 pruning backoff #95
Conversation
Codecov Report
@@ Coverage Diff @@
## gsv1.1 #95 +/- ##
=======================================
Coverage 81.81% 81.81%
=======================================
Files 1 1
Lines 11 11
=======================================
Hits 9 9
Misses 2 2 Continue to review full report at Codecov.
|
wemeetagain
force-pushed
the
cayman/gs1.1-backoff
branch
from
beeb149
to
4eb492c
Compare
ts/index.ts
Outdated
| */ | ||
| _clearBackoff (): void { | ||
| // we only clear once every 15 ticks to avoid iterating over the maps too much | ||
| if (this.heartbeatTicks % 15 !== 0) { |
There was a problem hiding this comment.
Where does the 15 come from? Should this be a constant/configuration option?
There was a problem hiding this comment.
Also, should we reset it instead?
There was a problem hiding this comment.
15 is just pulled from go-libp2p-pubsub. I'll pull it into a constant.
We can't reset it, at least not here, because other features will be relying on the ticks in a similar way (eg: https://github.com/ChainSafe/js-libp2p-gossipsub/pull/96/files#diff-86c7c8f2b553297cee358fb131db4f7bR239)
In go-libp2p-pubsub, this counter is never reset, even on stop. Shouldn't be a problem for us though, even at a heartbeat every 100ms, we should have over 10 million years before getting out of safe integer range.
Implements https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#prune-backoff-and-peer-exchange prune backoff, not peer exchange
Follows the go-libp2p-pubsub implementation closely.
Extends
ControlPruneprotobuf message and interface to include "peer info"s and backoff. (For now, only backoff is used)Adds
backoffMap, a map of maps, indexed by topic, then peer, with a value of a timestamp. If a peer sends a graft for a topic while a backoff entry exists, immediately prune, re-extend the backoff period.Adds a
heartbeatTickscounter, will be used for opportunistic grafting in a future PR. Here it's used to clear old backoff entries once every 15 heartbeats.Adds a
_makePruneControlPruneconstructor. For now, the PX section is not there.